fixme reminder

Author: pcrespov

services/catalog/src/simcore_service_catalog/core/background_tasks.py

@@ -70,9 +70,7 @@ def _by_version(t: tuple[ServiceKey, ServiceVersion]) -> Version:
             (service_key, service_version)
         ]
         try:
-            ## Set deprecation date to null (is valid date value for postgres)
-
-            # DEFAULT policies
+            # 1. Evaluate DEFAULT ownership and access rights
             (
                 owner_gid,
                 service_access_rights,
@@ -82,12 +80,13 @@ def _by_version(t: tuple[ServiceKey, ServiceVersion]) -> Version:
                 product_name=app.state.default_product_name,
             )
 
-            # AUTO-UPGRADE PATCH policy
-            inherited_data = await access_rights.inherit_from_previous_release(
+            # 2. Inherit access rights from the latest compatible release
+            inherited_data = await access_rights.inherit_from_latest_compatible_release(
                 service_metadata=service_metadata,
                 services_repo=services_repo,
             )
 
+            # 3. Aggregates access rights and metadata updates
             service_access_rights += inherited_data["access_rights"]
             service_access_rights = access_rights.reduce_access_rights(
                 service_access_rights
@@ -98,7 +97,7 @@ def _by_version(t: tuple[ServiceKey, ServiceVersion]) -> Version:
                 **inherited_data["metadata_updates"],
             }
 
-            # set the service in the DB
+            # 4. Create or update the service in the database
             await services_repo.create_or_update_service(
                 ServiceMetaDataDBCreate(**metadata_updates, owner=owner_gid),
                 service_access_rights,

services/catalog/src/simcore_service_catalog/service/access_rights.py

@@ -144,8 +144,11 @@ async def _find_previous_compatible_release(
         service_metadata.key,
         major=new_version.major,
         minor=new_version.minor,
+        limit_count=5,
     )
 
+    # FIXME: deprecated versions hsould not coutn!!!
+
     # latest_releases is sorted from newer to older
     for release in latest_releases:
         # COMPATIBILITY RULE:
@@ -156,7 +159,7 @@ async def _find_previous_compatible_release(
     return None
 
 
-async def inherit_from_previous_release(
+async def inherit_from_latest_compatible_release(
     services_repo: ServicesRepository, *, service_metadata: ServiceMetaDataPublished
 ) -> InheritedData:
     """

services/catalog/tests/unit/with_dbs/test_service_access_rights.py

@@ -16,7 +16,7 @@
 from simcore_service_catalog.repository.services import ServicesRepository
 from simcore_service_catalog.service.access_rights import (
     evaluate_default_service_ownership_and_rights,
-    inherit_from_previous_release,
+    inherit_from_latest_compatible_release,
     reduce_access_rights,
 )
 from sqlalchemy.ext.asyncio import AsyncEngine
@@ -205,7 +205,7 @@ async def test_auto_upgrade_policy(
     assert service_access_rights[0].product_name == target_product
 
     # Inheritance policy (both access rights and metadata)
-    inherited_data = await inherit_from_previous_release(
+    inherited_data = await inherit_from_latest_compatible_release(
         services_repo, service_metadata=new_service_metadata
     )