minor

Author: sanderegg

packages/aws-library/tests/test_ec2_client.py

@@ -26,6 +26,7 @@
 )
 from faker import Faker
 from moto.server import ThreadedMotoServer
+from pydantic import TypeAdapter
 from pytest_mock import MockerFixture
 from settings_library.ec2 import EC2Settings
 from types_aiobotocore_ec2 import EC2Client
@@ -531,7 +532,8 @@ async def test_set_instance_tags(
 
     # now remove some, this should do nothing
     await simcore_ec2_api.remove_instances_tags(
-        created_instances, tag_keys=[AWSTagKey("whatever_i_dont_exist")]
+        created_instances,
+        tag_keys=[TypeAdapter(AWSTagKey).validate_python("whatever_i_dont_exist")],
     )
     await _assert_instances_in_ec2(
         ec2_client,
@@ -589,7 +591,6 @@ async def test_launch_instances_with_multi_subnets(
     aws_security_group_id: str,
     aws_ami_id: str,
 ):
-    """Test that launch_instances uses multiple valid subnets correctly."""
     await _assert_no_instances_in_ec2(ec2_client)
 
     # Create additional valid subnets for testing
@@ -608,8 +609,6 @@ async def test_launch_instances_with_multi_subnets(
         iam_instance_profile="",
     )
 
-    # TODO: simulate InsufficientInstanceCapacity on the first subnet only
-
     # This should succeed using one of the valid subnets
     instances = await simcore_ec2_api.launch_instances(
         ec2_instance_config,

packages/pytest-simcore/src/pytest_simcore/aws_ec2_service.py

@@ -60,6 +60,7 @@ async def aws_vpc_id(
     print(f"<-- Deleted Vpc in AWS with {vpc_id=}")
 
 
+@pytest.fixture
 def create_subnet_cidr_block(faker: Faker) -> Callable[[], str]:
     def _() -> str:
         return faker.ipv4_public(network=True)