removed unused

Author: Andrei Neagu

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/director_v0/_public_client.py

@@ -8,8 +8,6 @@
 )
 from models_library.projects import ProjectID
 from models_library.projects_nodes_io import NodeID
-from models_library.service_settings_labels import SimcoreServiceLabels
-from models_library.services_base import ServiceKeyVersion
 from models_library.users import UserID
 from pydantic import TypeAdapter
 from servicelib.fastapi.app_state import SingletonInAppStateMixin
@@ -49,17 +47,7 @@ async def get_running_service_details(
             _unenvelope_or_raise_error(response)
         )
 
-    async def get_service_labels(  # required
-        self, service: ServiceKeyVersion
-    ) -> SimcoreServiceLabels:
-        response = await DirectorV0ThinClient.get_from_app_state(
-            self.app
-        ).get_services_labels(service)
-        return TypeAdapter(SimcoreServiceLabels).validate_python(
-            _unenvelope_or_raise_error(response)
-        )
-
-    async def get_running_services(  # required
+    async def get_running_services(
         self, user_id: UserID | None = None, project_id: ProjectID | None = None
     ) -> list[RunningDynamicServiceDetails]:
         response = await DirectorV0ThinClient.get_from_app_state(

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/director_v0/_thin_client.py

@@ -1,11 +1,8 @@
-import urllib.parse
-
 from common_library.unset import as_dict_exclude_none
 from fastapi import FastAPI, status
 from httpx import Response
 from models_library.projects import ProjectID
 from models_library.projects_nodes_io import NodeID
-from models_library.services_base import ServiceKeyVersion
 from models_library.users import UserID
 from servicelib.fastapi.app_state import SingletonInAppStateMixin
 from servicelib.fastapi.http_client import AttachLifespanMixin
@@ -49,13 +46,6 @@ async def get_running_interactive_service_details(
     ) -> Response:
         return await self.client.get(f"/running_interactive_services/{node_id}")
 
-    @retry_on_errors()
-    @expect_status(status.HTTP_200_OK)
-    async def get_services_labels(self, service: ServiceKeyVersion) -> Response:
-        return await self.client.get(
-            f"/services/{urllib.parse.quote_plus(service.key)}/{service.version}/labels"
-        )
-
     @retry_on_errors()
     @expect_status(status.HTTP_200_OK)
     async def get_running_interactive_services(

services/dynamic-scheduler/tests/unit/test_services_director_v0.py

@@ -13,7 +13,6 @@
 from models_library.projects import ProjectID
 from models_library.projects_nodes_io import NodeID
 from models_library.service_settings_labels import SimcoreServiceLabels
-from models_library.services_base import ServiceKeyVersion
 from pydantic import TypeAdapter
 from pytest_simcore.helpers.typing_env import EnvVarsDict
 from simcore_service_dynamic_scheduler.services.director_v0 import (
@@ -43,13 +42,6 @@ def legacy_service_details(
     )
 
 
-@pytest.fixture
-def service_labels() -> SimcoreServiceLabels:
-    return TypeAdapter(SimcoreServiceLabels).validate_python(
-        SimcoreServiceLabels.model_json_schema()["examples"][0]
-    )
-
-
 @pytest.fixture
 def mock_director_v0(
     node_id: NodeID,
@@ -78,14 +70,6 @@ def mock_director_v0(
             json={"data": [legacy_service_details.model_dump(mode="json")]},
         )
 
-        respx_mock.request(
-            method="GET",
-            path="/v0/services/simcore/services/dynamic/test/1.0.0/labels",
-        ).respond(
-            status_code=200,
-            json={"data": service_labels.model_dump(mode="jsone"), "error": None},
-        )
-
         yield
 
 
@@ -100,16 +84,6 @@ async def test_get_running_service_details(
     assert result == legacy_service_details
 
 
-async def test_get_service_labels(
-    mock_director_v0: None, app: FastAPI, service_labels: SimcoreServiceLabels
-):
-    client = DirectorV0PublicClient.get_from_app_state(app)
-    labels = await client.get_service_labels(
-        ServiceKeyVersion(key="simcore/services/dynamic/test", version="1.0.0")
-    )
-    assert labels.model_dump(mode="json") == service_labels.model_dump(mode="json")
-
-
 async def test_get_running_services(
     mock_director_v0: None,
     app: FastAPI,