Skip to content

Commit b1d5920

Browse files
author
Andrei Neagu
committed
refactor
1 parent 2fe521e commit b1d5920

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
from models_library.projects_nodes_io import NodeID
2+
from models_library.rabbitmq_basic_types import RPCNamespace
3+
4+
5+
def get_rpc_namespace(node_id: NodeID) -> RPCNamespace:
6+
return RPCNamespace.from_entries({"service": "dy-sidecar", "node_id": f"{node_id}"})

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_sidecar/disk.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import logging
22

33
from models_library.projects_nodes_io import NodeID
4-
from models_library.rabbitmq_basic_types import RPCMethodName, RPCNamespace
4+
from models_library.rabbitmq_basic_types import RPCMethodName
55
from pydantic import TypeAdapter
66

77
from ....logging_utils import log_decorator
88
from ... import RabbitMQRPCClient
9+
from ._utils import get_rpc_namespace
910

1011
_logger = logging.getLogger(__name__)
1112

@@ -16,9 +17,7 @@ async def free_reserved_disk_space(
1617
*,
1718
node_id: NodeID,
1819
) -> None:
19-
rpc_namespace = RPCNamespace.from_entries(
20-
{"service": "dy-sidecar", "node_id": f"{node_id}"}
21-
)
20+
rpc_namespace = get_rpc_namespace(node_id)
2221
result = await rabbitmq_rpc_client.request(
2322
rpc_namespace,
2423
TypeAdapter(RPCMethodName).validate_python("free_reserved_disk_space"),

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_sidecar/disk_usage.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@
22

33
from models_library.api_schemas_dynamic_sidecar.telemetry import DiskUsage
44
from models_library.projects_nodes_io import NodeID
5-
from models_library.rabbitmq_basic_types import RPCMethodName, RPCNamespace
5+
from models_library.rabbitmq_basic_types import RPCMethodName
66
from pydantic import TypeAdapter
77

88
from ....logging_utils import log_decorator
99
from ... import RabbitMQRPCClient
10+
from ._utils import get_rpc_namespace
1011

1112
_logger = logging.getLogger(__name__)
1213

@@ -18,9 +19,7 @@ async def update_disk_usage(
1819
node_id: NodeID,
1920
usage: dict[str, DiskUsage],
2021
) -> None:
21-
rpc_namespace = RPCNamespace.from_entries(
22-
{"service": "dy-sidecar", "node_id": f"{node_id}"}
23-
)
22+
rpc_namespace = get_rpc_namespace(node_id)
2423
result = await rabbitmq_rpc_client.request(
2524
rpc_namespace,
2625
TypeAdapter(RPCMethodName).validate_python("update_disk_usage"),

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_sidecar/volumes.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
import logging
22

33
from models_library.projects_nodes_io import NodeID
4-
from models_library.rabbitmq_basic_types import RPCMethodName, RPCNamespace
4+
from models_library.rabbitmq_basic_types import RPCMethodName
55
from models_library.sidecar_volumes import VolumeCategory, VolumeStatus
66
from pydantic import TypeAdapter
77

88
from ....logging_utils import log_decorator
99
from ... import RabbitMQRPCClient
10+
from ._utils import get_rpc_namespace
1011

1112
_logger = logging.getLogger(__name__)
1213

@@ -19,9 +20,7 @@ async def save_volume_state(
1920
status: VolumeStatus,
2021
category: VolumeCategory,
2122
) -> None:
22-
rpc_namespace = RPCNamespace.from_entries(
23-
{"service": "dy-sidecar", "node_id": f"{node_id}"}
24-
)
23+
rpc_namespace = get_rpc_namespace(node_id)
2524
result = await rabbitmq_rpc_client.request(
2625
rpc_namespace,
2726
TypeAdapter(RPCMethodName).validate_python("save_volume_state"),

0 commit comments

Comments
 (0)