renamed

Author: Andrei Neagu

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_sidecar/disk.py

@@ -12,14 +12,14 @@
 
 
 @log_decorator(_logger, level=logging.DEBUG)
-async def free_reserved_disk_space(
+async def delete_reserved_disk(
     rabbitmq_rpc_client: RabbitMQRPCClient,
     *,
     node_id: NodeID,
 ) -> None:
     rpc_namespace = get_rpc_namespace(node_id)
     result = await rabbitmq_rpc_client.request(
         rpc_namespace,
-        TypeAdapter(RPCMethodName).validate_python("free_reserved_disk_space"),
+        TypeAdapter(RPCMethodName).validate_python("delete_reserved_disk"),
     )
     assert result is None  # nosec

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/disk.py

@@ -11,4 +11,4 @@
     status_code=status.HTTP_204_NO_CONTENT,
 )
 async def free_reserved_disk_space() -> None:
-    disk.remove_reserved_disk_space()
+    disk.delete_reserved_disk()

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rpc/_disk.py

@@ -7,5 +7,5 @@
 
 
 @router.expose()
-async def free_reserved_disk_space(_: FastAPI) -> None:
-    disk.remove_reserved_disk_space()
+async def delete_reserved_disk(_: FastAPI) -> None:
+    disk.delete_reserved_disk()

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/reserved_space.py

@@ -28,7 +28,7 @@ def _write_random_binary_file(
             bytes_written += current_chunk_size
 
 
-def remove_reserved_disk_space() -> None:
+def delete_reserved_disk() -> None:
     _RESERVED_DISK_SPACE_NAME.unlink(missing_ok=True)
 
 

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/services/disk.py

@@ -1,5 +1,5 @@
-from ..core.reserved_space import remove_reserved_disk_space
+from ..core.reserved_space import delete_reserved_disk
 
-__all__: tuple[str, ...] = ("remove_reserved_disk_space",)
+__all__: tuple[str, ...] = ("delete_reserved_disk",)
 
 # nopycln: file

services/dynamic-sidecar/tests/conftest.py

@@ -30,7 +30,7 @@
 )
 from settings_library.redis import RedisSettings
 from simcore_service_dynamic_sidecar.core.reserved_space import (
-    remove_reserved_disk_space,
+    delete_reserved_disk,
 )
 
 logger = logging.getLogger(__name__)
@@ -366,6 +366,6 @@ def mock_metrics_params(faker: Faker) -> CreateServiceMetricsAdditionalParams:
 
 @pytest.fixture
 def cleanup_reserved_disk_space() -> Iterator[None]:
-    remove_reserved_disk_space()
+    delete_reserved_disk()
     yield
-    remove_reserved_disk_space()
+    delete_reserved_disk()

services/dynamic-sidecar/tests/unit/api/rpc/test__disk.py

@@ -21,7 +21,7 @@ async def test_free_reserved_disk_space(
 
     settings: ApplicationSettings = app.state.settings
 
-    result = await disk.free_reserved_disk_space(
+    result = await disk.delete_reserved_disk(
         rpc_client,
         node_id=settings.DY_SIDECAR_NODE_ID,
     )

services/dynamic-sidecar/tests/unit/test_core_reserved_space.py

@@ -7,7 +7,7 @@
 from simcore_service_dynamic_sidecar.core.application import create_base_app
 from simcore_service_dynamic_sidecar.core.reserved_space import (
     _RESERVED_DISK_SPACE_NAME,
-    remove_reserved_disk_space,
+    delete_reserved_disk,
 )
 
 
@@ -22,5 +22,5 @@ def test_reserved_disk_space_workflow(
         ByteSize
     ).validate_python("10MiB")
 
-    remove_reserved_disk_space()
+    delete_reserved_disk()
     assert not _RESERVED_DISK_SPACE_NAME.exists()