refactor to use settings instead of property name

Author: Andrei Neagu

packages/service-library/src/servicelib/fastapi/docker.py

@@ -20,22 +20,9 @@
 
 
 def get_lifespan_remote_docker_client(
-    docker_api_proxy_settings_property_name: str,
+    settings: DockerApiProxysettings,
 ) -> LifespanGenerator:
-    """Ensures `setup` and `teardown` for the remote docker client.
-
-    Arguments:
-        docker_api_proxy_settings_property_name -- if the name is `PROP_NAME`
-        then it should be accessible as `app.state.settings.PROP_NAME`
-
-    Returns:
-        docker client lifespan manager
-    """
-
     async def _(app: FastAPI) -> AsyncIterator[State]:
-        settings: DockerApiProxysettings = getattr(
-            app.state.settings, docker_api_proxy_settings_property_name
-        )
 
         session: ClientSession | None = None
         if settings.DOCKER_API_PROXY_USER and settings.DOCKER_API_PROXY_PASSWORD:

services/docker-api-proxy/tests/integration/conftest.py

@@ -39,12 +39,14 @@ class ApplicationSetting(BaseApplicationSettings):
             Field(json_schema_extra={"auto_default_from_env": True}),
         ]
 
+    settings = ApplicationSetting.create_from_envs()
+
     app = FastAPI(
         lifespan=combine_lifespans(
-            get_lifespan_remote_docker_client("DOCKER_API_PROXY")
+            get_lifespan_remote_docker_client(settings.DOCKER_API_PROXY)
         )
     )
-    app.state.settings = ApplicationSetting.create_from_envs()
+    app.state.settings = settings
 
     return app
 

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py

@@ -55,7 +55,9 @@ def create_app(settings: ApplicationSettings | None = None) -> FastAPI:
         lifespan_service_tracker,
         lifespan_deferred_manager,
         lifespan_status_monitor,
-        get_lifespan_remote_docker_client("DYNAMIC_SCHEDULER_DOCKER_API_PROXY"),
+        get_lifespan_remote_docker_client(
+            app_settings.DYNAMIC_SCHEDULER_DOCKER_API_PROXY
+        ),
     ]
 
     if app_settings.DYNAMIC_SCHEDULER_PROMETHEUS_INSTRUMENTATION_ENABLED: