refactor

Author: odeimaiz

services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js

@@ -565,16 +565,7 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
         const nodeId = e.getData();
         if (nodeId) {
           studyTreeItem.resetSelection();
-          const workbench = this.getStudy().getWorkbench();
-          const node = workbench.getNode(nodeId);
-          if (node) {
-            this.__populateSecondaryColumn(node);
-            this.__openIframeTab(node);
-            node.getIFrame().maximizeIFrame(true);
-          }
-          this.__loggerView.setCurrentNodeId(nodeId);
-          this.__workbenchUI.nodeSelected(nodeId);
-
+          this.fullscreenNode(nodeId);
           this.getStudy().getUi().setCurrentNodeId(nodeId);
         }
       }, this);
@@ -1198,19 +1189,23 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
 
     fullscreenNode: function(nodeId) {
       const node = this.getStudy().getWorkbench().getNode(nodeId);
-      if (node.isDynamic()) {
+      if (node && node.isDynamic()) {
         qx.event.Timer.once(() => {
+          this.__populateSecondaryColumn(node);
           this.__openIframeTab(node);
           node.getIFrame().maximizeIFrame(true);
         }, this, 10);
       }
+      this.__loggerView.setCurrentNodeId(nodeId);
+      this.__workbenchUI.nodeSelected(nodeId);
     },
 
     openFirstNode: function() {
       const validNodes = this.getStudy().getNonFrontendNodes();
       if (validNodes.length === 1 && validNodes[0].isDynamic()) {
         const dynamicNode = validNodes[0];
         this.fullscreenNode(dynamicNode.getNodeId());
+        this.getStudy().getUi().setCurrentNodeId(dynamicNode.getNodeId());
       } else {
         this.setMaximized(false);
         this.nodeSelected(this.getStudy().getUuid());

services/static-webserver/client/source/class/osparc/ui/message/Loading.js

@@ -108,7 +108,7 @@ qx.Class.define("osparc.ui.message.Loading", {
     __maxButton: null,
 
     __buildLayout: function() {
-      this._add(new qx.ui.core.Spacer(), {
+      this._add(new qx.ui.core.Widget(), {
         column: 0,
         row: 0
       });
@@ -209,6 +209,7 @@ qx.Class.define("osparc.ui.message.Loading", {
     __createMaximizeToolbar: function() {
       const maximize = false;
       const maxButton = this.__maxButton = osparc.widget.PersistentIframe.createToolbarButton(maximize).set({
+        maxHeight: 25,
         label: osparc.widget.PersistentIframe.getZoomLabel(maximize),
         icon: osparc.widget.PersistentIframe.getZoomIcon(maximize),
       });