Rename legacy --> classic

Author: mrnicegyu11

packages/postgres-database/src/simcore_postgres_database/migration/versions/354b5d921312_introduce_legacy_service_identification_.py

@@ -21,7 +21,7 @@ def upgrade():
     op.add_column(
         "services_meta_data",
         sa.Column(
-            "is_legacy_dynamic_service",
+            "is_classic_dynamic_service",
             sa.Boolean(),
             server_default=sa.text("false"),
             nullable=False,
@@ -32,5 +32,5 @@ def upgrade():
 
 def downgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.drop_column("services_meta_data", "is_legacy_dynamic_service")
+    op.drop_column("services_meta_data", "is_classic_dynamic_service")
     # ### end Alembic commands ###

packages/postgres-database/src/simcore_postgres_database/models/services.py

@@ -120,11 +120,11 @@
         "A fixed time before this date, service is marked as deprecated.",
     ),
     sa.Column(
-        "is_legacy_dynamic_service",
+        "is_classic_dynamic_service",
         sa.Boolean,
         nullable=False,
         server_default=sa.false(),
-        doc="Is the service a legacy-style dynamic service? This is false for comp-services and special items like filepickers.",
+        doc="Is the service a legacy-style classic dynamic service? This is false for comp-services and special items like filepickers.",
     ),
     sa.PrimaryKeyConstraint("key", "version", name="services_meta_data_pk"),
 )

services/catalog/src/simcore_service_catalog/core/background_tasks.py

@@ -89,7 +89,7 @@ def _by_version(t: tuple[ServiceKey, ServiceVersion]) -> Version:
             )
 
             # set the service in the DB
-            _is_legacy_dynamic_service: bool = (
+            _is_classic_dynamic_service: bool = (
                 service_metadata.inputs_path is None
                 and service_metadata.outputs_path is None
                 and service_metadata.state_paths is None
@@ -98,7 +98,7 @@ def _by_version(t: tuple[ServiceKey, ServiceVersion]) -> Version:
                 ServiceMetaDataDBCreate(
                     **service_metadata.model_dump(exclude_unset=True, exclude={""}),
                     owner=owner_gid,
-                    is_legacy_dynamic_service=_is_legacy_dynamic_service,
+                    _is_classic_dynamic_service=_is_classic_dynamic_service,
                 ),
                 service_access_rights,
             )

services/catalog/src/simcore_service_catalog/models/services_db.py

@@ -118,7 +118,7 @@ class ServiceMetaDataDBCreate(BaseModel):
 
     # lifecycle
     deprecated: datetime | None = None
-    is_legacy_dynamic_service: bool = False
+    _is_classic_dynamic_service: bool = False
 
     @staticmethod
     def _update_json_schema_extra(schema: JsonDict) -> None: