Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 16, 2024

What do these changes do?

#6353 introduced a new state in the progress status report of dynamic services.
E2E was broken because of it.
This PR fixes it.

Bonus:

  • fixes the Makefile that was broken

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Sep 16, 2024
@sanderegg sanderegg added this to the Doppelbock milestone Sep 16, 2024
@sanderegg sanderegg self-assigned this Sep 16, 2024
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (10419c1).
Report is 540 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6363      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.6%     
=========================================
  Files          10    1485    +1475     
  Lines         214   61365   +61151     
  Branches       25    2066    +2041     
=========================================
+ Hits          181   54119   +53938     
- Misses         23    6929    +6906     
- Partials       10     317     +307     
Flag Coverage Δ
integrationtests 64.5% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1434 files with indirect coverage changes

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Much appreciated.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@sanderegg sanderegg merged commit e4326eb into ITISFoundation:master Sep 16, 2024
@sanderegg sanderegg deleted the e2e/adding-service-startup-phase branch September 16, 2024 08:15
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants