Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Sep 16, 2024

What do these changes do?

Upgrades the api-server service to pydantic v2.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Sep 16, 2024
@giancarloromeo giancarloromeo added this to the Doppelbock milestone Sep 16, 2024
@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 89.32956% with 113 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@6d6f5c5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...-library/src/models_library/utils/serialization.py 22.2% 14 Missing ⚠️
...ary/src/models_library/utils/json_serialization.py 65.6% 6 Missing and 5 partials ⚠️
.../models_library/utils/pydantic_fields_extension.py 37.5% 10 Missing ⚠️
...ackages/aws-library/src/aws_library/ec2/_models.py 52.6% 9 Missing ⚠️
...models_library/utils/_original_fastapi_encoders.py 57.8% 5 Missing and 3 partials ⚠️
.../models_library/api_schemas_directorv2/clusters.py 66.6% 5 Missing ⚠️
...odels-library/src/models_library/projects_nodes.py 68.7% 5 Missing ⚠️
...src/models_library/api_schemas_webserver/groups.py 66.6% 4 Missing ⚠️
...els-library/src/models_library/user_preferences.py 60.0% 4 Missing ⚠️
...ages/settings-library/src/settings_library/base.py 87.8% 4 Missing ⚠️
... and 23 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6371   +/-   ##
=======================================================
  Coverage                         ?   82.2%           
=======================================================
  Files                            ?     391           
  Lines                            ?   13041           
  Branches                         ?    1145           
=======================================================
  Hits                             ?   10727           
  Misses                           ?    2169           
  Partials                         ?     145           
Flag Coverage Δ
unittests 82.2% <89.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/aws-library/src/aws_library/ec2/_client.py 100.0% <ø> (ø)
packages/aws-library/src/aws_library/s3/_client.py 95.3% <100.0%> (ø)
...kages/aws-library/src/aws_library/s3/_constants.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/s3/_errors.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/s3/_utils.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ssm/_client.py 97.7% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ssm/_errors.py 100.0% <100.0%> (ø)
...dask_task_models_library/container_tasks/docker.py 100.0% <100.0%> (ø)
...dask_task_models_library/container_tasks/errors.py 100.0% <100.0%> (ø)
...dask_task_models_library/container_tasks/events.py 91.8% <100.0%> (ø)
... and 147 more

@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Sep 16, 2024
@giancarloromeo giancarloromeo linked an issue Sep 18, 2024 that may be closed by this pull request
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots

See analysis details on SonarCloud

@giancarloromeo giancarloromeo deleted the is4481/upgrade-api-server branch September 27, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Major upgrade to pydantic 2.0

1 participant