Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 18, 2024

What do these changes do?

When a user manages to log in using a very very small screen, the User Menu button, and therefore, the Logout button are inaccessible.

In that scenario, this PR will make a dialog pop up and suggest the user to log out.

Bonus:

  • Show study location in Study Details

VeryverySmall

Location in Study Details:
image

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 18, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 18, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 18, 2024
@sonarqubecloud
Copy link

@odeimaiz odeimaiz changed the title 🎨 [Frontend] Small screens: Let them logout 🎨 [Frontend] Small screens: Let them go Sep 20, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 22, 2024 08:54
@odeimaiz odeimaiz added the UX_improvements UX Feedback during frontend testing process label Oct 22, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if i close (i.e. press x) in the logout screen? Can I still logout?

@odeimaiz
Copy link
Member Author

what happens if i close (i.e. press x) in the logout screen? Can I still logout?

You will have missed the chance to properly logout.

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about removing the X not possible? then the only option is to logout or close the tab

@odeimaiz
Copy link
Member Author

odeimaiz commented Oct 22, 2024

what about removing the X not possible? then the only option is to logout or close the tab

It can be done, but I find that option too aggressive. If the user closes that window, I assume they know the implications and know what they are doing.

@odeimaiz odeimaiz enabled auto-merge (squash) October 22, 2024 15:35
@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit b857ace into ITISFoundation:master Oct 23, 2024
51 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature UX_improvements UX Feedback during frontend testing process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants