Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Sep 25, 2024

What do these changes do?

Tests inside packages/service-library/tests/deferred_tasks/test_deferred_tasks.py would be flaky due to a missing process. This is not taken into account.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK changed the title 🐛 Flaky test 🐛 Fixes flaky tests in service-library test_deferred_tasks.py Sep 25, 2024
@GitHK GitHK self-assigned this Sep 25, 2024
@GitHK GitHK added a:services-library issues on packages/service-libs bug buggy, it does not work as expected labels Sep 25, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Sep 25, 2024
@GitHK GitHK marked this pull request as ready for review September 25, 2024 06:43
@GitHK GitHK requested a review from pcrespov as a code owner September 25, 2024 06:43
@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.5%. Comparing base (cafbf96) to head (ff340c7).
Report is 584 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6439      +/-   ##
=========================================
+ Coverage    84.5%   85.5%    +0.9%     
=========================================
  Files          10    1190    +1180     
  Lines         214   52218   +52004     
  Branches       25     935     +910     
=========================================
+ Hits          181   44654   +44473     
- Misses         23    7405    +7382     
- Partials       10     159     +149     
Flag Coverage Δ
unittests 85.5% <ø> (+0.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1200 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@GitHK GitHK enabled auto-merge (squash) September 25, 2024 12:35
@sonarqubecloud
Copy link

@GitHK GitHK merged commit ca3cc8c into ITISFoundation:master Sep 25, 2024
60 of 61 checks passed
@GitHK GitHK deleted the pr-osparc-september-flaky-tests branch September 25, 2024 13:43
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:services-library issues on packages/service-libs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants