- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
          🎨 adding folder_id to project resource
          #6460
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    🎨 adding folder_id to project resource
  
  #6460
              Conversation
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff            @@
##           master   #6460      +/-   ##
=========================================
+ Coverage    84.5%   88.9%    +4.3%     
=========================================
  Files          10    1245    +1235     
  Lines         214   54624   +54410     
  Branches       25     871     +846     
=========================================
+ Hits          181   48581   +48400     
- Misses         23    5911    +5888     
- Partials       10     132     +122     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
…robuliak66/osparc-simcore into add-folder-id-to-project-resource
        
          
                services/web/server/tests/unit/with_dbs/02/test_projects_states_handlers.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/projects/models.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
          
 | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. I left some suggestions.
Summary of this PR: essentially you are now passing folder_id as part of the response model. correcty?



What do these changes do?
folder_idto project resource (This folder ID depends on the context of the user retrieving the project, as the user may have the shared project in their private folder.)Related issue/s
How to test
Dev-ops checklist