Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Sep 27, 2024

What do these changes do?

  • ✨ introduce '/projects:search' full search across all folders and all workspaces the user can access. This will be presented on the front-end as a flat list.

Related issue/s

How to test

test_workspaces__list_projects_full_search.py

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 changed the title ✨ introduce '/projects:search' full search WIP: ✨ introduce '/projects:search' full search Sep 27, 2024
@codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.0%. Comparing base (cafbf96) to head (fdbef1c).
Report is 602 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6464      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.5%     
=========================================
  Files          10     364     +354     
  Lines         214   18199   +17985     
  Branches       25       0      -25     
=========================================
+ Hits          181   16031   +15850     
- Misses         23    2168    +2145     
+ Partials       10       0      -10     
Flag Coverage Δ
unittests 88.0% <100.0%> (+3.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mcore_service_webserver/projects/_crud_api_read.py 97.9% <100.0%> (ø)
...mcore_service_webserver/projects/_crud_handlers.py 92.3% <100.0%> (ø)
...ervice_webserver/projects/_crud_handlers_models.py 96.7% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 96.8% <100.0%> (ø)

... and 370 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Here are some some early comments as you requested :-)

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 30, 2024 08:21
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Sep 30, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: ✨ introduce '/projects:search' full search WIP: ✨ introduce /projects:search full search Sep 30, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pcrespov
Copy link
Member

is this still WIP?

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: ✨ introduce /projects:search full search ✨ introduce /projects:search full search Sep 30, 2024
@matusdrobuliak66
Copy link
Collaborator Author

is this still WIP?

no its not, please review it is ready to be merged

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 30, 2024 14:06
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 34ac81b into ITISFoundation:master Sep 30, 2024
56 of 57 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants