-
Notifications
You must be signed in to change notification settings - Fork 32
✨ introduce /projects:search full search
#6464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ introduce /projects:search full search
#6464
Conversation
…robuliak66/osparc-simcore into add-folder-id-to-project-resource
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6464 +/- ##
=========================================
+ Coverage 84.5% 88.0% +3.5%
=========================================
Files 10 364 +354
Lines 214 18199 +17985
Branches 25 0 -25
=========================================
+ Hits 181 16031 +15850
- Misses 23 2168 +2145
+ Partials 10 0 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Here are some some early comments as you requested :-)
services/web/server/src/simcore_service_webserver/projects/_crud_api_read.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_crud_handlers_models.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_crud_handlers_models.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/db.py
Outdated
Show resolved
Hide resolved
/projects:search full search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 👍
|
is this still WIP? |
/projects:search full search/projects:search full search
no its not, please review it is ready to be merged |
…arc-simcore into project-full-search
|
34ac81b
into
ITISFoundation:master



What do these changes do?
Related issue/s
How to test
test_workspaces__list_projects_full_search.pyDev-ops checklist