- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
✨ New repository helpers on asyncpg #6465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff            @@
##           master   #6465      +/-   ##
=========================================
- Coverage    84.5%   82.5%    -2.1%     
=========================================
  Files          10    1403    +1393     
  Lines         214   58184   +57970     
  Branches       25    1367    +1342     
=========================================
+ Hits          181   48029   +47848     
- Misses         23    9972    +9949     
- Partials       10     183     +173     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looking good, please find below once concern about a test
          
 | 
    



What do these changes do?
This PR implements some helper functions to build repositories effectively on top of
asyncpg, which is going to be the replacement ofaiopgin the entire repo (see #4529)asyncpgengine insimcore-postgres-databaselibrary testspass_or_acquire_connection: returns an connection or acquires a new one. If the latter, it gets destroyed on exit.transaction_contexts: allows (i.e., database units of work) also across multiple repository calls.tests/test_utils_repos.pyOneResourceRepoDemousing aforementioned utils intests/test_utils_repos.py. This class also demonstrate how the utils above can be used to build repositoriesVendor.has_landing_pagewas retiredRelated issue/s
How to test
Dev-ops checklist