- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
          🐛 Fixes duplicates in tags listings and new priority to enforce order 
          #6479
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    🐛 Fixes duplicates in tags listings and new priority to enforce order 
  
  #6479
              Conversation
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff            @@
##           master   #6479      +/-   ##
=========================================
+ Coverage    84.5%   89.2%    +4.6%     
=========================================
  Files          10    1325    +1315     
  Lines         214   55392   +55178     
  Branches       25     961     +936     
=========================================
+ Hits          181   49447   +49266     
- Misses         23    5792    +5769     
- Partials       10     153     +143     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
f25ce06    to
    f7c00b0      
    Compare
  
    priority to enforce order 
      86d1f9f    to
    e482324      
    Compare
  
            
          
                packages/postgres-database/src/simcore_postgres_database/utils_tags_sql.py
          
            Show resolved
            Hide resolved
        
              
          
                packages/postgres-database/src/simcore_postgres_database/utils_tags_sql.py
          
            Show resolved
            Hide resolved
        
              
          
                packages/postgres-database/src/simcore_postgres_database/utils_tags_sql.py
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍 I added some comments that came to mind while reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👌 .
access_rights is now an OR aggregation, which is great because it won't break anything. Eventually we will need to expose access_rights and my_access_rights, so that the frontend can show with whom the tags are shared.
e482324    to
    98662e5      
    Compare
  
    
          
 | 
    



What do these changes do?
Addressed issues and enhancements from Can use tags in services and list services grouped by tags #6202:
list_allno longer returns duplicate tags when user has two groups with access to them.get_tagsnow correctly returns the most permissive access rights by applying OR aggregation across all flags.priorityproperty for tags to enforce explicit ordering in listings.♻️ Refactor: Tags Repository:
asyncpg-based syntax with support fromutils_reposhelpers.tagsresource.🎨 Database Plugin Enhancements:
web-server'sdbplugin now sets up an additionalasyncpgenginetest_all_pg_engines_in_appfor details):aiopgengine (deprecated)asyncpgengine viasqlalchemy.ext.asyncio(new)asyncpgpool (deprecated)Related issue/s
How to test
Driving tests:
and
Dev-ops checklist
None