Skip to content

🐛 [Frontend] Guided Tours: point to visible selector or skip #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 1, 2024
Merged

🐛 [Frontend] Guided Tours: point to visible selector or skip #6481

merged 7 commits into from
Oct 1, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 1, 2024 •
edited by pcrespov
Loading

What do these changes do?

reported by @cosfor1

If the selector defined in the Guided Tour was present more than once, the frontend would try to point to the first match, but it could happen that the selector wasn't on screen. This PR will fix that scenario by pointing only at the first on-screen-match.

OnlyIfVisible

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 1, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 1, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 1, 2024
@odeimaiz odeimaiz changed the title rename and refactor 🐛 [Frontend] Guided Tours: point to visible selector or skip Oct 1, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 1, 2024 12:22
pcrespov
pcrespov approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

GitHK
GitHK reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) October 1, 2024 13:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit 7a2dbda into ITISFoundation:master Oct 1, 2024
51 checks passed
@odeimaiz odeimaiz deleted the fix/guided-tour-w-folders branch October 1, 2024 13:51
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@odeimaiz @mrnicegyu11
🐛 [Frontend] Guided Tours: point to visible selector or skip (ITISFou…
38ea07a 
…ndation#6481)
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@ignapas ignapas ignapas approved these changes

@pcrespov pcrespov pcrespov approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

Guided Tours look buggy in sim4life-staging.cloud

4 participants

@odeimaiz @ignapas @GitHK @pcrespov