- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
🎨 improve project full search #6483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 improve project full search #6483
Conversation
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff            @@
##           master   #6483      +/-   ##
=========================================
+ Coverage    84.5%   87.8%    +3.2%     
=========================================
  Files          10    1204    +1194     
  Lines         214   52509   +52295     
  Branches       25     950     +925     
=========================================
+ Hits          181   46103   +45922     
- Misses         23    6228    +6205     
- Partials       10     178     +168     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
        
          
                packages/service-library/src/servicelib/aiohttp/requests_validation.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/postgres-database/src/simcore_postgres_database/models/projects.py
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/projects/_crud_api_read.py
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/projects/_crud_handlers.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/projects/_crud_api_read.py
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
          
 | 
    



What do these changes do?
order_byandtag_idsquery parameters as discussed with @odeimaiz🗃️ Make project owner mandatory (this is already the case in the production, only the DB constrain was missing)Related issue/s
How to test
test__list_projects_full_search_with_query_parametersDev-ops checklist