Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 2, 2024

What do these changes do?

Stop polling service's state, check once at start up and then listen to serviceStatus websocket event.

serviceStatus

Related issue/s

How to test

Dev-ops checklist

@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.6%. Comparing base (cafbf96) to head (b844f92).
Report is 631 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6487      +/-   ##
=========================================
+ Coverage    84.5%   86.6%    +2.0%     
=========================================
  Files          10    1261    +1251     
  Lines         214   54996   +54782     
  Branches       25     872     +847     
=========================================
+ Hits          181   47642   +47461     
- Misses         23    7235    +7212     
- Partials       10     119     +109     
Flag Coverage Δ
unittests 86.6% <100.0%> (+2.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...odels_library/api_schemas_dynamic_sidecar/ports.py 100.0% <100.0%> (ø)
...ecar/modules/notifications/_notifications_ports.py 100.0% <ø> (ø)

... and 1245 files with indirect coverage changes

@odeimaiz odeimaiz self-assigned this Oct 2, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 2, 2024
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature labels Oct 2, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Listen to socket events: serviceStatus, stateInputPorts and stateOutputPorts ✨ [Frontend] Listen to websocket events: serviceStatus, stateInputPorts and stateOutputPorts Oct 2, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Listen to websocket events: serviceStatus, stateInputPorts and stateOutputPorts ✨ [Frontend] Listen to websocket serviceStatus event Oct 3, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Listen to websocket serviceStatus event ✨ [Frontend] Listen to the serviceStatus websocket event Oct 3, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 14, 2024 13:19
@odeimaiz odeimaiz enabled auto-merge (squash) October 14, 2024 13:58
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Let's see how it behaves.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit ee3ac42 into ITISFoundation:master Oct 15, 2024
56 of 57 checks passed
@odeimaiz odeimaiz deleted the feature/power-to-the-socket branch October 15, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

6 participants