- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
π¨ efs improvements (group extra properties) ποΈ #6493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¨ efs improvements (group extra properties) ποΈ #6493
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests β 
 Additional details and impacted files@@            Coverage Diff            @@
##           master   #6493      +/-   ##
=========================================
+ Coverage    84.5%   89.2%    +4.7%     
=========================================
  Files          10    1329    +1319     
  Lines         214   55436   +55222     
  Branches       25     961     +936     
=========================================
+ Hits          181   49495   +49314     
- Misses         23    5788    +5765     
- Partials       10     153     +143     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
          
 | 
    
        
          
                packages/postgres-database/src/simcore_postgres_database/models/groups_extra_properties.py
          
            Show resolved
            Hide resolved
        
              
          
                ...rector-v2/src/simcore_service_director_v2/modules/db/repositories/groups_extra_properties.py
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Please consider my suggestions before merging



What do these changes do?
My strategy:
Related issue/s
How to test
Dev-ops checklist