- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
♻️ Add common library #6495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Add common library #6495
Conversation
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6495   +/-   ##
=======================================================
  Coverage                         ?   80.7%           
=======================================================
  Files                            ?     211           
  Lines                            ?    8080           
  Branches                         ?     478           
=======================================================
  Hits                             ?    6526           
  Misses                           ?    1495           
  Partials                         ?      59           
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Q: What is the advantage of having this library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ask me for a review again when done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, we'll need to add it the the service where we use it.
@giancarloromeo add yourself to the code owners file as well 😃
          
 | 
    
19e3923
      into
      
  
    ITISFoundation:pydantic_v2_migration
  
    



What do these changes do?
The idea is to create a common-library that will contain all the
domain-agnosticand reusable components (base classes, validators).Before, everything was included into
models-library.Related issue/s
How to test
Dev-ops checklist