Skip to content

🐛 Fixes bad formatting while handling missing configuration errors #6501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2024
Merged

🐛 Fixes bad formatting while handling missing configuration errors #6501

merged 6 commits into from
Oct 8, 2024

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 8, 2024 •
edited
Loading

What do these changes do?

Fixes bad formatting while handling MissingGroupExtraPropertiesForProductError

  File "/home/scu/.venv/lib/python3.11/site-packages/simcore_service_webserver/users/_handlers.py", line 57, in wrapper
    frontend_msg = FMSG_MISSING_CONFIG_WITH_OEC.format(error_code)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'error_code'

Related issue/s

How to test

After the fix

  1. make up-prod
  2. in the db select a product (e.g. osparc)
  3. remove the groups_extra_properties row associated to that product -> this will make the configuration invalid and in this commit this error was not handled correctly.
  4. try to login
  5. WAS displaying a strange message, now
    image

Dev-ops checklist

None

@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Oct 8, 2024
@pcrespov pcrespov added this to the MartinKippenberger milestone Oct 8, 2024
@pcrespov pcrespov self-assigned this Oct 8, 2024
@codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.7%. Comparing base (cafbf96) to head (c9e544f).
Report is 624 commits behind head on master.

Files with missing lines Patch % Lines
...r/src/simcore_service_webserver/users/_handlers.py 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6501      +/-   ##
=========================================
+ Coverage    84.5%   87.7%    +3.2%     
=========================================
  Files          10    1204    +1194     
  Lines         214   52542   +52328     
  Branches       25     950     +925     
=========================================
+ Hits          181   46127   +45946     
- Misses         23    6237    +6214     
- Partials       10     178     +168
Flag Coverage Δ
integrationtests 64.7% <0.0%> (?)
unittests 85.3% <66.6%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...library/src/servicelib/aiohttp/rest_middlewares.py 74.2% <100.0%> (ø)
...r/src/simcore_service_webserver/users/_handlers.py 92.7% <0.0%> (ø)

... and 1212 files with indirect coverage changes

@pcrespov pcrespov marked this pull request as ready for review October 8, 2024 16:20
@pcrespov pcrespov enabled auto-merge (squash) October 8, 2024 16:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit 54f9bcd into ITISFoundation:master Oct 8, 2024
57 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 14, 2024
@pcrespov @mrnicegyu11
🐛 Fixes bad formatting while handling missing configuration errors (I…
475fd13 
…TISFoundation#6501)
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 15, 2024
Closed
18 tasks
This was referenced Oct 29, 2024
Closed
Closed
@pcrespov pcrespov deleted the fix/bad-format branch December 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@pcrespov pcrespov

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

3 participants

@pcrespov @GitHK @matusdrobuliak66