Skip to content

🐛 Logs out previously logged in users to avoid authentication issues with the cookie which is passed in all subdomains #6507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

🐛 Logs out previously logged in users to avoid authentication issues with the cookie which is passed in all subdomains #6507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64ec4e7
remove legacy cookie and renamed cookie
Oct 9, 2024
8aede74
fixed vendor tests
Oct 9, 2024
0eed0cc
revert cookie deletion
Oct 10, 2024
e439438
revert previous code
Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/settings-library/src/settings_library/utils_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import binascii
from typing import Final

DEFAULT_SESSION_COOKIE_NAME: Final[str] = "osparc-sc"
DEFAULT_SESSION_COOKIE_NAME: Final[str] = "osparc-sc-v2"
_32_BYTES_LENGTH: Final[int] = 32


Expand Down
2 changes: 1 addition & 1 deletion services/docker-compose-dev-vendors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ services:
# auth
- traefik.http.middlewares.${SWARM_STACK_NAME}_manual-auth.forwardauth.address=http://${WEBSERVER_HOST}:${WEBSERVER_PORT}/v0/auth:check
- traefik.http.middlewares.${SWARM_STACK_NAME}_manual-auth.forwardauth.trustForwardHeader=true
- traefik.http.middlewares.${SWARM_STACK_NAME}_manual-auth.forwardauth.authResponseHeaders=Set-Cookie,osparc-sc
- traefik.http.middlewares.${SWARM_STACK_NAME}_manual-auth.forwardauth.authResponseHeaders=Set-Cookie,osparc-sc-v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why do we need a new name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not currently. Forgot to close the PR

# routing
- traefik.http.services.${SWARM_STACK_NAME}_manual.loadbalancer.server.port=80
- traefik.http.services.${SWARM_STACK_NAME}_manual.loadbalancer.healthcheck.path=/
Expand Down
Loading