Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Oct 11, 2024

What do these changes do?

Upgrade the EFS guardian service to Pydantic v2.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Oct 11, 2024
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Oct 11, 2024
@giancarloromeo giancarloromeo added this to the MartinKippenberger milestone Oct 11, 2024
@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pydantic_v2_migration@329b00d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6516   +/-   ##
=======================================================
  Coverage                         ?   97.2%           
=======================================================
  Files                            ?      17           
  Lines                            ?     254           
  Branches                         ?       0           
=======================================================
  Hits                             ?     247           
  Misses                           ?       7           
  Partials                         ?       0           
Flag Coverage Δ
unittests 97.2% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/simcore_service_efs_guardian/core/application.py 96.2% <100.0%> (ø)
.../src/simcore_service_efs_guardian/core/settings.py 100.0% <100.0%> (ø)
...c/simcore_service_efs_guardian/exceptions/_base.py 100.0% <100.0%> (ø)

@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo changed the title WIP: ⬆️ Upgrade EFS guardian service WIP: ⬆️ Upgrade EFS guardian service (Pydantic v2) Oct 11, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review October 11, 2024 07:52
@giancarloromeo giancarloromeo changed the title WIP: ⬆️ Upgrade EFS guardian service (Pydantic v2) Upgrade EFS guardian service (Pydantic v2) Oct 11, 2024
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@giancarloromeo giancarloromeo merged commit 6786b92 into ITISFoundation:pydantic_v2_migration Oct 11, 2024
54 of 58 checks passed
@giancarloromeo giancarloromeo deleted the is4481/upgrade-efs-guardian branch October 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants