- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar #6534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar #6534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check that stuff with time delta
        
          
                services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py
          
            Show resolved
            Hide resolved
        
              
          
                services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/models/shared_store.py
          
            Show resolved
            Hide resolved
        
              
          
                packages/common-library/src/common_library/pydantic_settings_validators.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/models-library/src/models_library/services_creation.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few comments. Thank you very much for your support here.
        
          
                packages/common-library/src/common_library/pydantic_type_adapters.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/common-library/src/common_library/pydantic_settings_validators.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/models-library/src/models_library/projects_nodes_io.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/models-library/src/models_library/services_creation.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers.py
          
            Show resolved
            Hide resolved
        
              
          
                services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/models/shared_store.py
          
            Show resolved
            Hide resolved
        
      | 
           There are still failing tests. And a bunch of deprecated  https://github.com/ITISFoundation/osparc-simcore/actions/runs/11342435177/job/31542848296?pr=6534  | 
    
…-osparc-pydantic-v2-dynamic-sidecar2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes in scripts/maintenance/computational-clusters. Thanks!
        
          
                packages/models-library/src/models_library/api_schemas_dynamic_sidecar/containers.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/pytest-simcore/src/pytest_simcore/helpers/playwright_sim4life.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                scripts/maintenance/computational-clusters/autoscaled_monitor/core.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
          
 | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all the changes
01b4c09
      into
      
  
    ITISFoundation:pydantic_v2_migration
  
    Co-authored-by: Andrei Neagu <[email protected]>



What do these changes do?
Fixes unit tests for
dynamic-sidecar.Related issue/s
How to test
Dev-ops checklist