Skip to content

🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar #6534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Oct 18, 2024
Merged

🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar #6534

merged 26 commits into from
Oct 18, 2024

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 15, 2024 •
edited
Loading

What do these changes do?

Fixes unit tests for dynamic-sidecar.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Oct 15, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Oct 15, 2024
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Oct 15, 2024
@GitHK GitHK mentioned this pull request Oct 15, 2024
Closed
1 task
@GitHK GitHK changed the title 🎨 Fixed unit-tests for dynamic-sidecar 🎨 pydnatic2 migration: fixed unit-tests for dynamic-sidecar Oct 15, 2024
@codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.98305% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@c9a48cc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...odels-library/src/models_library/services_types.py 56.2% 7 Missing ⚠️
...-library/src/common_library/pydantic_validators.py 87.5% 2 Missing ⚠️
...kages/settings-library/src/settings_library/ssm.py 66.6% 0 Missing and 1 partial ⚠️
...ynamic_sidecar/modules/outputs/_directory_utils.py 66.6% 1 Missing ⚠️
...ervice_dynamic_sidecar/modules/outputs/_manager.py 93.3% 1 Missing ⚠️
...c_sidecar/modules/user_services_preferences/_db.py 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6534   +/-   ##
=======================================================
  Coverage                         ?   81.9%           
=======================================================
  Files                            ?     660           
  Lines                            ?   24603           
  Branches                         ?    1832           
=======================================================
  Hits                             ?   20162           
  Misses                           ?    4133           
  Partials                         ?     308
Flag Coverage Δ
unittests 81.9% <88.9%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/aws-library/src/aws_library/s3/_client.py 95.3% <100.0%> (ø)
...models-library/src/models_library/aiodocker_api.py 70.8% <100.0%> (ø)
...dels-library/src/models_library/rest_pagination.py 95.2% <100.0%> (ø)
...ibrary/src/models_library/rest_pagination_utils.py 84.6% <100.0%> (ø)
...ls-library/src/models_library/services_creation.py 100.0% <100.0%> (ø)
...s/models-library/src/models_library/services_io.py 80.7% <ø> (ø)
...s-library/src/models_library/services_resources.py 84.2% <ø> (ø)
...c/servicelib/aiohttp/long_running_tasks/_server.py 91.0% <100.0%> (ø)
...ice-library/src/servicelib/fastapi/docker_utils.py 94.7% <100.0%> (ø)
...c/servicelib/fastapi/long_running_tasks/_client.py 85.7% <100.0%> (ø)
... and 21 more

Andrei Neagu added 2 commits October 15, 2024 10:00
@GitHK GitHK marked this pull request as ready for review October 15, 2024 08:11
sanderegg
sanderegg reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check that stuff with time delta

@GitHK GitHK requested a review from sanderegg October 15, 2024 08:42
pcrespov
pcrespov approved these changes Oct 15, 2024
View reviewed changes
giancarloromeo
giancarloromeo approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments. Thank you very much for your support here.

@giancarloromeo
Copy link
Contributor

giancarloromeo commented Oct 15, 2024 •
edited
Loading

There are still failing tests. And a bunch of deprecated parse_obj and parse_obj_as that is better to migrate too.

https://github.com/ITISFoundation/osparc-simcore/actions/runs/11342435177/job/31542848296?pr=6534

@GitHK GitHK requested a review from giancarloromeo October 16, 2024 10:50
giancarloromeo
giancarloromeo approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👌

@GitHK GitHK changed the title 🎨 pydnatic2 migration: fixed unit-tests for dynamic-sidecar 🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar Oct 16, 2024
sanderegg
sanderegg requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes in scripts/maintenance/computational-clusters. Thanks!

@GitHK GitHK requested a review from sanderegg October 17, 2024 09:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sanderegg
sanderegg approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the changes

@GitHK GitHK merged commit 01b4c09 into ITISFoundation:pydantic_v2_migration Oct 18, 2024
38 of 58 checks passed
@GitHK GitHK deleted the pr-osparc-pydantic-v2-dynamic-sidecar2 branch October 18, 2024 06:06
@giancarloromeo giancarloromeo mentioned this pull request Oct 21, 2024
Closed
sanderegg pushed a commit that referenced this pull request Oct 22, 2024
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar (#6534)
e97258e 
Co-authored-by: Andrei Neagu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@GitHK GitHK

Labels

a:dynamic-sidecar dynamic-sidecar service

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

4 participants

@GitHK @giancarloromeo @pcrespov @sanderegg