♻️Pydantic V2 upgrade: autoscaling

[sanderegg]

What do these changes do?

Changes:

• AUTOSCALING_POLL_INTERVAL (and any timedelta types) must be defined as ISO8601 strings or integers/floats (e.g. "00:00:10" instead of "10" (this is not accepted anymore!!) ⚠️ DEvops
• Re-generated the packages/models-library/src/models_library/generated_models/docker_rest_api.py using pydanticV2, this will generate some issues in other places, will be fixed later (e.g. all fields are now snake cased)

Related issue/s

How to test

make devenv
source .venv/bin/activate
cd services/autoscaling
make install-dev
make mypy
make test-dev-unit

Dev-ops checklist

• https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1003
• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pydantic_v2_migration@5528772). Learn more about missing BASE report.

Additional details and impacted files

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6535   +/-   ##
=======================================================
  Coverage                         ?   73.1%           
=======================================================
  Files                            ?     159           
  Lines                            ?    8380           
  Branches                         ?     553           
=======================================================
  Hits                             ?    6126           
  Misses                           ?    2175           
  Partials                         ?      79           

Flag	Coverage Δ
unittests	73.1% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ackages/aws-library/src/aws_library/ec2/_models.py	89.0% <ø> (ø)
...toscaling/src/simcore_service_autoscaling/_meta.py	100.0% <100.0%> (ø)
...aling/src/simcore_service_autoscaling/constants.py	100.0% <100.0%> (ø)
...rc/simcore_service_autoscaling/core/application.py	100.0% <100.0%> (ø)
...ing/src/simcore_service_autoscaling/core/errors.py	100.0% <100.0%> (ø)
...g/src/simcore_service_autoscaling/core/settings.py	100.0% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_core.py	89.3% <100.0%> (ø)
...scaling/modules/auto_scaling_mode_computational.py	87.3% <100.0%> (ø)
...ng/src/simcore_service_autoscaling/modules/dask.py	89.3% <100.0%> (ø)
...ore_service_autoscaling/utils/auto_scaling_core.py	93.6% <100.0%> (ø)
... and 4 more

[giancarloromeo]

Thanks a lot.

Just a note: for performance, be sure to not instantiate TypeAdapters in loops/functions continuously called. In that case it's better to put their creation somewhere outside.

See: https://docs.pydantic.dev/latest/concepts/performance/#typeadapter-instantiated-once

[YuryHrytsuk]

Is there a related PR in osparc-config updating AUTOSCALING_POLL_INTERVAL?

[sanderegg]

Is there a related PR in osparc-config updating AUTOSCALING_POLL_INTERVAL?

@YuryHrytsuk this is coming...

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud