Skip to content

🐛🎨 [Frontend] Sim4Life.lite: Fix and add guided tours #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 17, 2024
Merged

🐛🎨 [Frontend] Sim4Life.lite: Fix and add guided tours #6541

merged 10 commits into from
Oct 17, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 15, 2024 •
edited
Loading

What do these changes do?

reported by @capbrown

  • 🐛 Fixes the Dashboard Guided Tour
  • 🎨 Adds Navigation Bar and Projects Guided Tours
  • 🐛 More fixes in other Guided Tours

GuidedTours

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 15, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 15, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 15, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 17, 2024 08:15
@odeimaiz odeimaiz enabled auto-merge (squash) October 17, 2024 08:20
jsaq007
jsaq007 previously requested changes Oct 17, 2024
View reviewed changes
pcrespov
pcrespov reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz requested a review from jsaq007 October 17, 2024 08:44
sanderegg
sanderegg reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

jsaq007
jsaq007 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit 1032d56 into ITISFoundation:master Oct 17, 2024
51 checks passed
This was referenced Oct 22, 2024
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

@GitHK GitHK GitHK approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@capbrown capbrown Awaiting requested review from capbrown

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

+1 more reviewer

@jsaq007 jsaq007 jsaq007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

Guided Tours Broken in S4L-lite

5 participants

@odeimaiz @jsaq007 @GitHK @pcrespov @sanderegg