- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
⬆️ ♻️ Upgrade pagination customisation in api-server #6545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ ♻️ Upgrade pagination customisation in api-server #6545
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff            @@
##           master   #6545      +/-   ##
=========================================
- Coverage    84.5%   66.8%   -17.8%     
=========================================
  Files          10     684     +674     
  Lines         214   33433   +33219     
  Branches       25     265     +240     
=========================================
+ Hits          181   22343   +22162     
- Misses         23   11029   +11006     
- Partials       10      61      +51     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
7d6e597    to
    015c887      
    Compare
  
    
          
 | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks



What do these changes do?
Enhancements to Customization in
fastapi_paginationand Fix forlimitQuery Parameter Customizationfastapi_paginationpage by removing version limit inconstraints.txtCustomizedPageto customise query parameters and name of thePagemodel. We also replaceFieldbyQueryto avoid error reported inconstraints.txt(AttributeError: 'FieldInfo' object has no attribute 'in_'). @giancarloromeo I believe this is also causing the same issues we see in ⬆️ Upgrade API server (Pydantic v2) #6511.REMINDER: @giancarloromeo when this is merged into
master, do not forget to resync your branches withmasterso you get this change.Related issue/s
How to test
Dev-ops checklist
None