Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 17, 2024

What do these changes do?

Second merge of master to the pydantic_v2_migration branch.

I had to manually resolve 150 conflicting files. @giancarloromeo @pcrespov @matusdrobuliak66 @sanderegg I expect you to merge this at least 2 times next week.
I'm not 100% sure if I omitted something but I did my best. Also fixed all failing packages after the merge.

Related issue/s

How to test

Dev-ops checklist

pcrespov and others added 30 commits September 9, 2024 14:54
@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@01b4c09). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ommon-library/src/common_library/errors_classes.py 50.0% 2 Missing ⚠️
...ls-library/src/models_library/rabbitmq_messages.py 88.8% 1 Missing ⚠️
.../src/simcore_service_dynamic_sidecar/core/utils.py 66.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6555   +/-   ##
=======================================================
  Coverage                         ?   81.9%           
=======================================================
  Files                            ?     661           
  Lines                            ?   24637           
  Branches                         ?    1832           
=======================================================
  Hits                             ?   20191           
  Misses                           ?    4139           
  Partials                         ?     307           
Flag Coverage Δ
unittests 81.9% <93.2%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/common-library/src/common_library/error_codes.py 80.0% <ø> (ø)
...odels_library/api_schemas_dynamic_sidecar/ports.py 100.0% <100.0%> (ø)
...rary/src/models_library/service_settings_labels.py 89.4% <ø> (ø)
...models_library/utils/_original_fastapi_encoders.py 49.3% <ø> (ø)
...library/src/servicelib/aiohttp/rest_middlewares.py 75.2% <100.0%> (ø)
.../service-library/src/servicelib/aiohttp/tracing.py 77.1% <100.0%> (ø)
...s/service-library/src/servicelib/logging_errors.py 100.0% <100.0%> (ø)
...es/service-library/src/servicelib/logging_utils.py 79.5% <100.0%> (ø)
packages/service-library/src/servicelib/utils.py 91.6% <100.0%> (ø)
...es/service-library/src/servicelib/utils_secrets.py 92.3% <100.0%> (ø)
... and 7 more

@GitHK GitHK changed the title Pr osparc merge mmaster topy2 branch2 pydantic2 migration: merge master -> pydantic_v2_migration Oct 17, 2024
@GitHK GitHK changed the title pydantic2 migration: merge master -> pydantic_v2_migration ♻️ pydantic2 migration: merge master -> pydantic_v2_migration Oct 17, 2024
@GitHK GitHK changed the title ♻️ pydantic2 migration: merge master -> pydantic_v2_migration Merge master in pydantic_v2_migration 17.10.2024 Oct 17, 2024
@GitHK GitHK marked this pull request as ready for review October 18, 2024 05:49
@GitHK GitHK added this to the MartinKippenberger milestone Oct 18, 2024
@GitHK GitHK self-assigned this Oct 18, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud
Copy link

@GitHK GitHK merged commit b7384d4 into ITISFoundation:pydantic_v2_migration Oct 18, 2024
38 of 58 checks passed
@GitHK GitHK deleted the pr-osparc-merge-mmaster-topy2-branch2 branch October 18, 2024 06:29
@matusdrobuliak66
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants