Skip to content

Merge master in pydantic_v2_migration 17.10.2024 #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 140 commits into from
Oct 18, 2024
Merged

Merge master in pydantic_v2_migration 17.10.2024 #6555

merged 140 commits into from
Oct 18, 2024

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 17, 2024 •
edited
Loading

What do these changes do?

Second merge of master to the pydantic_v2_migration branch.

I had to manually resolve 150 conflicting files. @giancarloromeo @pcrespov @matusdrobuliak66 @sanderegg I expect you to merge this at least 2 times next week.
I'm not 100% sure if I omitted something but I did my best. Also fixed all failing packages after the merge.

Related issue/s

How to test

Dev-ops checklist

pcrespov and others added 30 commits September 9, 2024 14:54
@pcrespov
🎨 Healtcheck diagnostics sensor is now optional (ITISFoundation#6327)
b74bae4
@matusdrobuliak66
🎨 folder deletion (ITISFoundation#6324)
7405274
@pcrespov
⬆️ upgrades guvicorn dependencies in webserver (ITISFoundation#6336)
e28d3bd
@odeimaiz
🎨 [Frontend] Folder & Workspaces: Missing features I (ITISFoundation#…
a3b8340 
…6317)
@odeimaiz
🐛 [Frontend] Fix: Unique session id (ITISFoundation#6335)
891312a
@odeimaiz
🎨 [e2e]: Increase S4L's timeout when there is a workspace to download (…
2be918d 
…ITISFoundation#6338)
@sanderegg
🎨Autoscaling: Add option to allow a new node to join a cluster direct…
1320b69 
…ly active (🚨) (ITISFoundation#6334)
@sanderegg
🐛Autoscaling/Comp backend: drain retired nodes so that they can be re…
5b35cfe 
…-used (ITISFoundation#6345)
@matusdrobuliak66
🐛 adjust storage user project permission based on new logic with work…
0722af4 
…spaces (ITISFoundation#6337)
@odeimaiz @matusdrobuliak66
🎨 [Frontend] Workspaces & Folders: Show them as a tree (ITISFoundatio…
9de4d19 
…n#6343)

Co-authored-by: matusdrobuliak66 <[email protected]>
@odeimaiz
🎨 [Frontend] React to a 401 Unauthorized (ITISFoundation#6261)
4e4a70c
@YuryHrytsuk
🔒️ Make Redis Client support TLS (ITISFoundation#6342)
913ff92
@odeimaiz
✨ [Frontend] New product: TIP lite 🚨 (ITISFoundation#6346)
3457e01
@pcrespov
🐛 Fixes catalog's synchronization background task continues errors du…
9380819 
…e to faulty service info (ITISFoundation#6344)
@matusdrobuliak66
🎨 add running_time_in_hours to /services/-/aggregated-usages (ITISF…
1692f4b 
…oundation#6350)
@jsaq007
Added some fallback icons for apple devices (ITISFoundation#6351)
fbdfe63
@odeimaiz
🎨 [Frontend] Workspaces: Prettify tree I (ITISFoundation#6349)
ed97990
@odeimaiz
🐛 [Frontend] Move to folder (ITISFoundation#6355)
2173264
@matusdrobuliak66
🐛 fix issue with workspace permissions (ITISFoundation#6354)
7f5e97c
@odeimaiz
🎨 [Frontend] Credits summary: Show time (ITISFoundation#6356)
8527559
@GitHK
🎨 Adds new progress bar to track starting software (ITISFoundation#…
62765b6 
…6353)

Co-authored-by: Andrei Neagu <[email protected]>
@odeimaiz
🐛 [Frontend] Folders tree: Fixes I (ITISFoundation#6358)
d5d06ee
@matusdrobuliak66
🐛 fix version control doesn't populate projects_to_products table (I…
5ebce8d 
…TISFoundation#6357)
@odeimaiz
🎨 [Frontend] TIP lite: add teaser button (ITISFoundation#6359)
4699e19
@sanderegg
🎨E2E: adapt test to new service startup status (ITISFoundation#6363)
e4326eb
@odeimaiz
🎨🐛 [Frontend] Folders tree: improvements (ITISFoundation#6360)
c21b1fb
@odeimaiz
🎨🐛 [Frontend] Folders tree: improvements II (ITISFoundation#6364)
662030a 
On behalf of @odeimaiz
@matusdrobuliak66
🐛 do not allow moving folder to a child folder (ITISFoundation#6370)
f272c8f
@odeimaiz
🎨 [Frontend] Prettify markdown's outcome (ITISFoundation#6369)
4518e6d
@GitHK @matusdrobuliak66
🐛 Fixed Redis issue where keys ended up in the wrong deployment. (ITI…
22c4456 
…SFoundation#6368)

Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: matusdrobuliak66 <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@01b4c09). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ommon-library/src/common_library/errors_classes.py 50.0% 2 Missing ⚠️
...ls-library/src/models_library/rabbitmq_messages.py 88.8% 1 Missing ⚠️
.../src/simcore_service_dynamic_sidecar/core/utils.py 66.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6555   +/-   ##
=======================================================
  Coverage                         ?   81.9%           
=======================================================
  Files                            ?     661           
  Lines                            ?   24637           
  Branches                         ?    1832           
=======================================================
  Hits                             ?   20191           
  Misses                           ?    4139           
  Partials                         ?     307
Flag Coverage Δ
unittests 81.9% <93.2%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/common-library/src/common_library/error_codes.py 80.0% <ø> (ø)
...odels_library/api_schemas_dynamic_sidecar/ports.py 100.0% <100.0%> (ø)
...rary/src/models_library/service_settings_labels.py 89.4% <ø> (ø)
...models_library/utils/_original_fastapi_encoders.py 49.3% <ø> (ø)
...library/src/servicelib/aiohttp/rest_middlewares.py 75.2% <100.0%> (ø)
.../service-library/src/servicelib/aiohttp/tracing.py 77.1% <100.0%> (ø)
...s/service-library/src/servicelib/logging_errors.py 100.0% <100.0%> (ø)
...es/service-library/src/servicelib/logging_utils.py 79.5% <100.0%> (ø)
packages/service-library/src/servicelib/utils.py 91.6% <100.0%> (ø)
...es/service-library/src/servicelib/utils_secrets.py 92.3% <100.0%> (ø)
... and 7 more

@GitHK GitHK changed the title Pr osparc merge mmaster topy2 branch2 pydantic2 migration: merge master -> pydantic_v2_migration Oct 17, 2024
@GitHK GitHK changed the title pydantic2 migration: merge master -> pydantic_v2_migration ♻️ pydantic2 migration: merge master -> pydantic_v2_migration Oct 17, 2024
@GitHK GitHK changed the title ♻️ pydantic2 migration: merge master -> pydantic_v2_migration Merge master in pydantic_v2_migration 17.10.2024 Oct 17, 2024
@GitHK GitHK marked this pull request as ready for review October 18, 2024 05:49
@GitHK GitHK added this to the MartinKippenberger milestone Oct 18, 2024
@GitHK GitHK self-assigned this Oct 18, 2024
sanderegg
sanderegg approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GitHK GitHK merged commit b7384d4 into ITISFoundation:pydantic_v2_migration Oct 18, 2024
38 of 58 checks passed
@GitHK GitHK deleted the pr-osparc-merge-mmaster-topy2-branch2 branch October 18, 2024 06:29
@matusdrobuliak66
Copy link
Collaborator

matusdrobuliak66 commented Oct 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@ignapas ignapas Awaiting requested review from ignapas

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@GitHK GitHK

Labels

None yet

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

8 participants

@GitHK @matusdrobuliak66 @odeimaiz @sanderegg @pcrespov @YuryHrytsuk @jsaq007 @mrnicegyu11