🐛 [Frontend] Reuse client_session_id from socket's query instead of creating a new one
#6564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
odeimaiz
added
bug
odeimaiz
requested review from
GitHK,
matusdrobuliak66,
mguidon,
pcrespov and
sanderegg
mguidon
approved these changes
Oct 18, 2024
Member
mguidon
left a comment
mguidon
left a comment
There was a problem hiding this comment.
Great. Lets see if this helps.
odeimaiz
changed the title
client_session_id from socket's query instead of creating a new one
This was referenced Oct 22, 2024
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
After logging in, the frontend creates a
client_session_idused by the websocket and some projects related request headers. Thisclient_session_idis kept in thesessionStorageof the borwser.If somehow this one gets deleted or disappears, whenever it's required, the frontend will create a new one that will be only used by the projects related requests, the websocket after reconnecting it will keep the previous
client_session_id. This misalignment makes the Garbage Collector kill services that are started with this new session id.This PR fixes this scenario by checking (and reusing) if the websocket has a
client_session_idbefore creating a new one.Related issue/s
How to test
Dev-ops checklist