🐛E2E: fixes how videostreaming checked #6569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
t:maintenance
sanderegg
force-pushed
the
e2e/fix-sim4life-videochecking-code
branch
from
5a928ec to
27b8e2a
Compare
sanderegg
requested review from
YuryHrytsuk,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
mguidon,
mrnicegyu11 and
odeimaiz
odeimaiz
approved these changes
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6569 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1553 +1543
Lines 214 63560 +63346
Branches 25 2078 +2053
=========================================
+ Hits 181 56011 +55830
- Misses 23 7232 +7209
- Partials 10 317 +307
Flags with carried forward coverage won't be shown. Click here to find out more. |
pcrespov
approved these changes
Oct 21, 2024
packages/pytest-simcore/src/pytest_simcore/helpers/playwright_sim4life.py
Show resolved
Hide resolved
bisgaard-itis
approved these changes
Oct 21, 2024
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Cool, thanks for the fix
sanderegg
force-pushed
the
e2e/fix-sim4life-videochecking-code
branch
2 times, most recently
from
fa1ff95 to
a71ae27
Compare
sanderegg
force-pushed
the
e2e/fix-sim4life-videochecking-code
branch
from
a71ae27 to
c69a750
Compare
|
This was referenced Oct 22, 2024
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
the code checking the videostreaming was flawed and waiting now 15-20 seconds to check for the latest change in bitrate. If this happens to go faster then the check would wrongly fail.
Now, the test works differently and takes a minimum time to check that the bitrate changed (e.g. 5 seconds), which should usually work.
Related issue/s
How to test
Dev-ops checklist