🎨 [Frontend] Enh: Show pending service_message in loading page
#6570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
odeimaiz
added
UI/UX
UX_improvements
ignapas
approved these changes
Oct 21, 2024
odeimaiz
changed the title
service_message in loading page
odeimaiz
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
sanderegg
reviewed
Oct 21, 2024
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
how is it going to show with autoscaled deployments?
matusdrobuliak66
approved these changes
Oct 21, 2024
…-simcore into enh/show-pending-message
|
This was referenced Oct 22, 2024
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In this PR, if the backend provides a
service_messagewhile it'spending, the frontend will show it right above Node Startup Sequence.After some discussions with @sanderegg:
Since this message will most likely be the
no suitable node...message coming from docker and it's a bit pessimistic, it will only be shown after 10".Related issue/s
How to test
Dev-ops checklist