Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

What do these changes do?

Upgrade the director-v2 to Pydantic v2.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Oct 22, 2024
@giancarloromeo giancarloromeo added the a:director-v2 issue related with the director-v2 service label Oct 22, 2024
@giancarloromeo giancarloromeo added this to the MartinKippenberger milestone Oct 22, 2024
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Oct 22, 2024
@giancarloromeo giancarloromeo changed the title WIP: Upgrade director v2 service WIP: Upgrade director-v2 service (Pydantic v2) Oct 22, 2024
@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pydantic_v2_migration@bb61da5). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6572   +/-   ##
=======================================================
  Coverage                         ?   84.8%           
=======================================================
  Files                            ?     560           
  Lines                            ?   21750           
  Branches                         ?     628           
=======================================================
  Hits                             ?   18444           
  Misses                           ?    3189           
  Partials                         ?     117           
Flag Coverage Δ
unittests 84.8% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/models-library/src/models_library/errors.py 100.0% <100.0%> (ø)

@sonarqubecloud
Copy link

@sanderegg sanderegg deleted the branch ITISFoundation:pydantic_v2_migration October 22, 2024 21:29
@sanderegg sanderegg closed this Oct 22, 2024
@giancarloromeo giancarloromeo deleted the is4481/upgrade-director-v2 branch October 28, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants