-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fix opentelemetry errors in autoscaling microservice #6582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix opentelemetry errors in autoscaling microservice #6582
Conversation
… This enables it to talk with the opentelemetry collector
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6582 +/- ##
=========================================
+ Coverage 84.5% 86.0% +1.4%
=========================================
Files 10 1556 +1546
Lines 214 63674 +63460
Branches 25 2085 +2060
=========================================
+ Hits 181 54790 +54609
- Misses 23 8580 +8557
- Partials 10 304 +294
Flags with carried forward coverage won't be shown. Click here to find out more. |
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could add tests on the networks. Something like "assert service A reaches service B". We have a system level test in this repo where I will start adding tests that include the reverse proxy. I might also add some "connectivity" tests from A to B using the /status entrypoints between services.
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this will fix it, thanks.
Nevertheless the autoscaling is not in the default network because it did not need to be there, due to the rule of not adding unnecessary stuff if not needed. Where is this collector in the deployments? in a separate stack I guess?
Anyway thanks!
Yes the collector is in the ops-stack in |
|



What do these changes do?
Connect autoscaling microservice to
defaultnetwork in local dev-deploy. Enables autoscaling to communicate with the opentelemetry collector.Related issue/s
How to test
make build up-proddocker service logs master-simcore_autoscaling, see no more opentelemetry errorsDev-ops checklist