Skip to content

Conversation

@mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Oct 23, 2024

What do these changes do?

Connect autoscaling microservice to default network in local dev-deploy. Enables autoscaling to communicate with the opentelemetry collector.

Related issue/s

How to test

  1. make build up-prod
  2. Run docker service logs master-simcore_autoscaling, see no more opentelemetry errors

Dev-ops checklist

… This enables it to talk with the opentelemetry collector
@mrnicegyu11 mrnicegyu11 added bug buggy, it does not work as expected a:autoscaling autoscaling service in simcore's stack labels Oct 23, 2024
@mrnicegyu11 mrnicegyu11 added this to the MartinKippenberger milestone Oct 23, 2024
@mrnicegyu11 mrnicegyu11 self-assigned this Oct 23, 2024
@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.0%. Comparing base (cafbf96) to head (6326b37).
Report is 670 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6582      +/-   ##
=========================================
+ Coverage    84.5%   86.0%    +1.4%     
=========================================
  Files          10    1556    +1546     
  Lines         214   63674   +63460     
  Branches       25    2085    +2060     
=========================================
+ Hits          181   54790   +54609     
- Misses         23    8580    +8557     
- Partials       10     304     +294     
Flag Coverage Δ
unittests 86.0% <ø> (+1.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1505 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could add tests on the networks. Something like "assert service A reaches service B". We have a system level test in this repo where I will start adding tests that include the reverse proxy. I might also add some "connectivity" tests from A to B using the /status entrypoints between services.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this will fix it, thanks.

Nevertheless the autoscaling is not in the default network because it did not need to be there, due to the rule of not adding unnecessary stuff if not needed. Where is this collector in the deployments? in a separate stack I guess?

Anyway thanks!

@mrnicegyu11
Copy link
Member Author

Ok this will fix it, thanks.

Nevertheless the autoscaling is not in the default network because it did not need to be there, due to the rule of not adding unnecessary stuff if not needed. Where is this collector in the deployments? in a separate stack I guess?

Anyway thanks!

Yes the collector is in the ops-stack in osparc-simcore and in the jaeger stack in osparc-ops-environments

@mrnicegyu11 mrnicegyu11 merged commit 5569079 into ITISFoundation:master Oct 24, 2024
31 of 32 checks passed
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:autoscaling autoscaling service in simcore's stack bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants