-
Notifications
You must be signed in to change notification settings - Fork 32
🐛Deferred tasks: set default log level of messages in Faststream broker to DEBUG #6589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Deferred tasks: set default log level of messages in Faststream broker to DEBUG #6589
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6589 +/- ##
=========================================
+ Coverage 84.5% 87.6% +3.0%
=========================================
Files 10 1217 +1207
Lines 214 52982 +52768
Branches 25 958 +933
=========================================
+ Hits 181 46452 +46271
- Misses 23 6353 +6330
- Partials 10 177 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
@sanderegg why do we set to debug level by default and without a way to override it? |
@YuryHrytsuk this is the log level of all messages going through the RabbitBroker class in faststream library. This leads to the 1000s of messages that you saw in master.
|
Ah, you mean that by setting it to DEBUG we will always filter them out with INFO (or further) log levels? Is it correct? P.S. I was initially confused since it looked like now we will generate even more logs because we set some "service" on DEBUG level |
@YuryHrytsuk yes. Unless the LOG_LEVEL is set to DEBUG in the configuration.
|
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is an emergency and you will revert it back, right?



What do these changes do?
This PR sets the default log level of faststream RabbitBroker to DEBUG.
@GitHK will need to review this, as this can't just be that so many messages are created here.
An issue was created for him to review this.
Related issue/s
How to test
Dev-ops checklist