Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 24, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Oct 24, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 24, 2024
@sanderegg sanderegg self-assigned this Oct 24, 2024
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration_do_not_squash_updates@7be9541). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...-sidecar/src/simcore_service_dask_sidecar/utils.py 40.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##             pydantic_v2_migration_do_not_squash_updates   #6591   +/-   ##
=============================================================================
  Coverage                                               ?   81.2%           
=============================================================================
  Files                                                  ?     203           
  Lines                                                  ?    8466           
  Branches                                               ?      23           
=============================================================================
  Hits                                                   ?    6875           
  Misses                                                 ?    1585           
  Partials                                               ?       6           
Flag Coverage Δ
unittests 81.2% <90.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...common-library/src/common_library/serialization.py 58.3% <100.0%> (ø)
...service_dask_sidecar/computational_sidecar/core.py 97.2% <100.0%> (ø)
...dask_sidecar/computational_sidecar/docker_utils.py 91.5% <100.0%> (ø)
...rvice_dask_sidecar/computational_sidecar/errors.py 100.0% <100.0%> (ø)
...rvice_dask_sidecar/computational_sidecar/models.py 95.8% <100.0%> (ø)
...car/src/simcore_service_dask_sidecar/dask_utils.py 97.7% <100.0%> (ø)
...car/src/simcore_service_dask_sidecar/file_utils.py 95.7% <100.0%> (ø)
...decar/src/simcore_service_dask_sidecar/settings.py 100.0% <100.0%> (ø)
...-sidecar/src/simcore_service_dask_sidecar/tasks.py 92.5% <100.0%> (ø)
...-sidecar/src/simcore_service_dask_sidecar/utils.py 60.3% <40.0%> (ø)

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg merged commit 6199ed6 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Oct 24, 2024
40 of 58 checks passed
@sanderegg sanderegg deleted the migration/dask-sidecar branch October 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dask-service Any of the dask services: dask-scheduler/sidecar or worker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants