⬆️Migration: Storage

[sanderegg]

What do these changes do?

• migrate storage to pydantic V2
• fixed json_serialization to understand new pydantic v2 Url type
• Removed AnyUrlLegacy and replaced with standard pydantic v2 AnyUrl type

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 91.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.7%. Comparing base (fb48eb1) to head (0f9d6a0).
Report is 2 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Files with missing lines	Patch %	Lines
...service_storage/datcore_adapter/datcore_adapter.py	25.0%	3 Missing ⚠️
...rage/src/simcore_service_storage/simcore_s3_dsm.py	72.7%	3 Missing ⚠️
...es/storage/src/simcore_service_storage/settings.py	87.5%	2 Missing ⚠️

Additional details and impacted files

@@                              Coverage Diff                              @@
##           pydantic_v2_migration_do_not_squash_updates   #6599     +/-   ##
=============================================================================
+ Coverage                                         80.9%   82.7%   +1.7%     
=============================================================================
  Files                                              289     301     +12     
  Lines                                            10605   12212   +1607     
  Branches                                           346     164    -182     
=============================================================================
+ Hits                                              8584   10102   +1518     
- Misses                                            1975    2084    +109     
+ Partials                                            46      26     -20     

Flag	Coverage Δ
unittests	82.7% <91.1%> (+1.7%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../src/common_library/pydantic_networks_extension.py	100.0% <100.0%> (ø)
...rvice_dask_sidecar/computational_sidecar/models.py	95.9% <100.0%> (+<0.1%)	⬆️
...storage/src/simcore_service_storage/application.py	84.4% <ø> (ø)
...torage/datcore_adapter/datcore_adapter_settings.py	100.0% <100.0%> (ø)
...e/src/simcore_service_storage/db_file_meta_data.py	98.5% <100.0%> (ø)
...storage/src/simcore_service_storage/db_projects.py	100.0% <100.0%> (ø)
.../storage/src/simcore_service_storage/exceptions.py	100.0% <100.0%> (ø)
...e/src/simcore_service_storage/handlers_datasets.py	100.0% <ø> (ø)
...rage/src/simcore_service_storage/handlers_files.py	99.2% <100.0%> (ø)
...age/src/simcore_service_storage/handlers_health.py	100.0% <100.0%> (ø)
... and 8 more

... and 135 files with indirect coverage changes

[matusdrobuliak66]

💯

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[giancarloromeo]

Intentional?

[pcrespov]

he is ignoring it ;-b

[sanderegg]

@giancarloromeo yes. that is what I wrote to you in the chat yesterday.

[pcrespov]

he is ignoring it ;-b