-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 FIX: project patch when wallet not shared #6602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 FIX: project patch when wallet not shared #6602
Conversation
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6602 +/- ##
==========================================
- Coverage 87.87% 82.42% -5.46%
==========================================
Files 1552 606 -946
Lines 62417 30738 -31679
Branches 2085 265 -1820
==========================================
- Hits 54852 25335 -29517
+ Misses 7248 5342 -1906
+ Partials 317 61 -256
Continue to review full report in Codecov by Sentry.
|
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was it there then?
When I was introducing PATCH 5 months ago I thought it was needed. Probably because I started from the PUT project and there it was necessary because we were updating the workbench, which is not the case anymore. |
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
|
7e052f5
into
ITISFoundation:master



What do these changes do?
Related issue/s
How to test
Dev-ops checklist