Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 25, 2024

What do these changes do?

Extend the Navigation Bar testing and some User Menu testing.

It also adds a test that would detect the bug as mentioned by @sanderegg in this comment.

Related issue/s

How to test

Dev-ops checklist

@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.68%. Comparing base (7e052f5) to head (7f7a435).

❗ There is a different number of reports uploaded between BASE (7e052f5) and HEAD (7f7a435). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7e052f5) HEAD (7f7a435)
integrationtests 7 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6603       +/-   ##
===========================================
- Coverage   87.87%   60.68%   -27.19%     
===========================================
  Files        1552      606      -946     
  Lines       62416    30738    -31678     
  Branches     2085      265     -1820     
===========================================
- Hits        54847    18653    -36194     
- Misses       7251    12024     +4773     
+ Partials      318       61      -257     
Flag Coverage Δ
integrationtests 60.68% <ø> (-4.04%) ⬇️
unittests ?
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 58.85% <ø> (-31.89%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.66% <ø> (-30.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
migration ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.99%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.61% <ø> (-29.73%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e052f5...7f7a435. Read the comment docs.

@odeimaiz odeimaiz marked this pull request as ready for review October 25, 2024 15:10
@odeimaiz odeimaiz enabled auto-merge (squash) October 25, 2024 15:10
@odeimaiz odeimaiz changed the title 🎨 [e2e frontend] Navigation Bar and User Menu 🎨 [e2e-frontend] Navigation Bar and User Menu Oct 25, 2024
@odeimaiz odeimaiz self-assigned this Oct 25, 2024
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Oct 25, 2024
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Oct 25, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 25, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 nice!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit fe95d75 into ITISFoundation:master Oct 28, 2024
49 of 50 checks passed
@odeimaiz odeimaiz deleted the e2e-frontend/user-menu branch October 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants