Skip to content

♻️ Remove PUT project endpoint #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 28, 2024
Merged

♻️ Remove PUT project endpoint #6604

merged 10 commits into from
Oct 28, 2024

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Oct 25, 2024 •
edited
Loading

What do these changes do?

  • ♻️ Remove PUT project endpoint

Related issue/s

How to test

Dev-ops checklist

@codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (7e052f5) to head (52cafcb).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6604      +/-   ##
==========================================
+ Coverage   87.87%   88.72%   +0.85%     
==========================================
  Files        1552     1262     -290     
  Lines       62416    53911    -8505     
  Branches     2085      885    -1200     
==========================================
- Hits        54847    47835    -7012     
+ Misses       7251     5942    -1309     
+ Partials      318      134     -184
Flag Coverage Δ
integrationtests 64.81% <50.00%> (+0.09%) ⬆️
unittests 86.37% <100.00%> (+0.54%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.13% <100.00%> (-0.02%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.16% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.26% <ø> (ø)
catalog 89.51% <ø> (ø)
clusters_keeper 98.85% <ø> (ø)
dask_sidecar 91.30% <ø> (ø)
datcore_adapter 94.02% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.87% <ø> (+0.13%) ⬆️
dynamic_scheduler 96.62% <ø> (ø)
dynamic_sidecar 89.70% <ø> (ø)
efs_guardian 87.03% <ø> (ø)
invitations 93.47% <ø> (ø)
migration ∅ <ø> (∅)
osparc_gateway_server 85.15% <ø> (-0.27%) ⬇️
payments 93.08% <ø> (ø)
resource_usage_tracker 87.36% <ø> (ø)
storage 89.73% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 89.27% <100.00%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e052f5...52cafcb. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 25, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: remove PUT project ♻️ Deprecate PUT project endpoint Oct 25, 2024
@matusdrobuliak66 matusdrobuliak66 added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work labels Oct 25, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Oct 25, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 25, 2024 14:54
odeimaiz
odeimaiz reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long live the PUT

pcrespov
pcrespov reviewed Oct 25, 2024
View reviewed changes
sanderegg
sanderegg approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why we keep it? there is no one else but the frontend using that entrypoint right? why keep it at all?

@matusdrobuliak66
Copy link
Collaborator Author

matusdrobuliak66 commented Oct 27, 2024

not sure I understand why we keep it? there is no one else but the frontend using that entrypoint right? why keep it at all?

UPDATE: I have removed the PUT endpoint 👍

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 27, 2024
Closed
1 task
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ Deprecate PUT project endpoint ♻️ Remove PUT project endpoint Oct 27, 2024
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 27, 2024 14:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 merged commit 27ceb6f into ITISFoundation:master Oct 28, 2024
87 of 90 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the remove-put-project branch October 28, 2024 11:39
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odeimaiz odeimaiz odeimaiz left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

Remove PUT call on projects endpoint

5 participants

@matusdrobuliak66 @giancarloromeo @pcrespov @odeimaiz @sanderegg