Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 28, 2024

What do these changes do?

  • Move the "Check organization" button to the right, so it is less distracting
  • Rename the button to "My organizations"
  • "Share with" might be confusing, because in this view we're publishing a template. Change it to "Publish for..."

PublishTemplate

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 28, 2024
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature labels Oct 28, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 28, 2024 14:18
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 28, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) October 28, 2024 14:19
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to merge "share" and "publish" into a single concept? AFAIK the latter is basically sharing a study as a template. E.g. would be "Share with ... " and/or "Share as template with ... "

@odeimaiz
Copy link
Member Author

Would it make sense to merge "share" and "publish" into a single concept? AFAIK the latter is basically sharing a study as a template. E.g. would be "Share with ... " and/or "Share as template with ... "

That's exactly what we are running away from.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@odeimaiz odeimaiz modified the milestones: MartinKippenberger, Caveman Oct 29, 2024
@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit 6db71c1 into ITISFoundation:master Oct 29, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish templates UI/sharing widget improvements

6 participants