Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Oct 28, 2024

What do these changes do?

Upgrade Director-v2 service to Pydantic v2.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added this to the MartinKippenberger milestone Oct 28, 2024
@giancarloromeo giancarloromeo self-assigned this Oct 28, 2024
@giancarloromeo giancarloromeo added a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work labels Oct 28, 2024
@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.44%. Comparing base (a00d55f) to head (6c9af46).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

❗ There is a different number of reports uploaded between BASE (a00d55f) and HEAD (6c9af46). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (a00d55f) HEAD (6c9af46)
unittests 30 1
Additional details and impacted files
@@                               Coverage Diff                                @@
##           pydantic_v2_migration_do_not_squash_updates    #6619       +/-   ##
================================================================================
- Coverage                                        85.52%   64.44%   -21.08%     
================================================================================
  Files                                             1560      648      -912     
  Lines                                            63404    31599    -31805     
  Branches                                          2207      316     -1891     
================================================================================
- Hits                                             54227    20365    -33862     
- Misses                                            8844    11174     +2330     
+ Partials                                           333       60      -273     
Flag Coverage Δ *Carryforward flag
integrationtests 64.87% <ø> (-0.21%) ⬇️ Carriedforward from a10e5b8
unittests 58.38% <ø> (-27.54%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.41% <ø> (-0.85%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 58.38% <ø> (ø)
director_v2 75.74% <ø> (-0.44%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.80% <ø> (-29.54%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.41% <ø> (-5.82%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.93% <ø> (-28.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00d55f...6c9af46. Read the comment docs.

@giancarloromeo giancarloromeo requested a review from GitHK November 14, 2024 10:26
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me this can be merged as soon a director-v2 tests are green

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@giancarloromeo
Copy link
Contributor Author

giancarloromeo commented Nov 14, 2024

@sanderegg, thank you for taking care after merge:

image
image
image

@giancarloromeo giancarloromeo merged commit f335bca into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 14, 2024
68 of 87 checks passed
@giancarloromeo giancarloromeo deleted the is4481/upgrade-director-v2-service branch November 14, 2024 12:24
@giancarloromeo giancarloromeo changed the title WIP: ⬆️ Upgrade Director v2 service (Pydantic v2) ⬆️ Upgrade Director v2 service (Pydantic v2) Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants