🐛 [Frontend] Fix probe #6620
Merged
🐛 [Frontend] Fix probe #6620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
requested review from
GitHK,
JavierGOrdonnez,
matusdrobuliak66,
pcrespov and
sanderegg
|
matusdrobuliak66
approved these changes
Oct 29, 2024
This was referenced Oct 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Spotted by @JavierGOrdonnez
There was a bug when removing some elements from the node when the Probe was populated. In this PR, the code was improved and refactored: instead of replacing elements, they will be just be reused.
Related issue/s
How to test
Dev-ops checklist