⬆️Pydantic V2: Diverse fixes after merges from master

[sanderegg]

What do these changes do?

• removed FieldNotRequired this is not supported anymore
• NOTE that writing

class MyClass:
  my_int: int | None

in pydantic V1 would validate when my_int was "forgotten" and set it as None. This is not anymore the case in V2 which is the expected behavior.

Also in V2, FieldNotRequired, which was abusing that concept is not supported anymore.

@matusdrobuliak66 @pcrespov Please check:

• services/payments/src/simcore_service_payments/models/db.py changes in example for PaymentsTransactionsDB and 'PaymentsMethodsDB' that were missing values

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[matusdrobuliak66]

thanks

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (afa0b3c) to head (367c12b).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files

@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6627      +/-   ##
===============================================================================
- Coverage                                        70.69%   70.55%   -0.15%     
===============================================================================
  Files                                             1029      922     -107     
  Lines                                            46799    42955    -3844     
  Branches                                          1243      434     -809     
===============================================================================
- Hits                                             33086    30308    -2778     
+ Misses                                           13492    12555     -937     
+ Partials                                           221       92     -129     

Flag	Coverage Δ		*Carryforward flag
integrationtests	64.78% <ø> (-0.01%)	⬇️	Carriedforward from 2e20fb8
unittests	83.44% <50.00%> (+2.60%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	83.79% <ø> (ø)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	70.00% <ø> (ø)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.44% <ø> (ø)
agent	97.21% <ø> (ø)
api_server	∅ <ø> (∅)
autoscaling	95.25% <ø> (ø)
catalog	∅ <ø> (∅)
clusters_keeper	98.85% <ø> (ø)
dask_sidecar	90.84% <ø> (ø)
datcore_adapter	93.14% <ø> (ø)
director	58.38% <ø> (ø)
director_v2	76.20% <ø> (ø)
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	59.66% <ø> (ø)
efs_guardian	87.12% <43.75%> (∅)
invitations	93.44% <ø> (ø)
osparc_gateway_server	85.41% <ø> (ø)
payments	92.98% <100.00%> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	89.63% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	59.66% <ø> (-0.02%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa0b3c...367c12b. Read the comment docs.

[GitHK]

Please double check my highlights

[sonarqubecloud]

Quality Gate failed

Failed conditions
6.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[pcrespov]

I wonder if the rest noticed this. perhaps add it in the description of the PR ?

[pcrespov]

Why you add Field when we only look for the default?

THOUGHT: I wonder if we should start using Annotated instead of abusing of the "exception to the rule" of adding a default (i.e. Field) that is not an instance of the type annotated. It kind of similar to the story with FieldRequired that exploited an edge case that now was removed.

class MyModel(BaseModel):
      foo: Annotated[LongTruncatedStr | None , Field(description="foo is the opposite of bar")] = None

Perhaps is an unnecessary burden ... it does not really pay off!

[pcrespov]

this is fine