Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 1, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work labels Nov 1, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 1, 2024
@sanderegg sanderegg self-assigned this Nov 1, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

@codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.44%. Comparing base (1fe311d) to head (0bdefb9).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6651      +/-   ##
===============================================================================
+ Coverage                                        67.21%   68.44%   +1.22%     
===============================================================================
  Files                                              873      759     -114     
  Lines                                            40617    35377    -5240     
  Branches                                          1390      258    -1132     
===============================================================================
- Hits                                             27301    24213    -3088     
+ Misses                                           13083    11104    -1979     
+ Partials                                           233       60     -173     
Flag Coverage Δ *Carryforward flag
integrationtests 64.78% <ø> (-0.01%) ⬇️ Carriedforward from 1fe311d
unittests 92.24% <ø> (+17.55%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.41% <ø> (ø)
agent 97.22% <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 98.85% <ø> (∅)
dask_sidecar 90.87% <ø> (∅)
datcore_adapter 93.17% <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.21% <ø> (-0.01%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.64% <ø> (ø)
efs_guardian 90.10% <ø> (∅)
invitations 93.49% <ø> (∅)
osparc_gateway_server 79.52% <ø> (ø)
payments ∅ <ø> (∅)
resource_usage_tracker 87.51% <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.70% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe311d...0bdefb9. Read the comment docs.

@sanderegg sanderegg merged commit 24218c1 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 1, 2024
61 of 74 checks passed
@sanderegg sanderegg deleted the fix-after-merge branch November 1, 2024 12:34
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants