Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 4, 2024

What do these changes do?

From real world usage (used and free are differente):

{
  "HOST":           DiskUsage(used=70385278976, free=466223489024, total=536608768000, used_percent=13.12),
  "INPUTS_VOLUMES": DiskUsage(used=70385111040, free=466223656960, total=536608768000, used_percent=13.12)
}

It means that measurements cn be different between two parallel calls (which is feasible since the disk could be used).

A different approach to raising an error would be to remove fields which are not supported (filter them out).

Bonus: deprecated unused code

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Nov 4, 2024
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Nov 4, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 4, 2024
@GitHK GitHK marked this pull request as ready for review November 4, 2024 12:22
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR, instead of raising, you are filtering and ignoring. right?

@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.10%. Comparing base (41817c8) to head (386a280).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (41817c8) and HEAD (386a280). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (41817c8) HEAD (386a280)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6660       +/-   ##
===========================================
- Coverage   87.85%   68.10%   -19.76%     
===========================================
  Files        1568      613      -955     
  Lines       63366    31343    -32023     
  Branches     2089      265     -1824     
===========================================
- Hits        55671    21345    -34326     
- Misses       7377     9937     +2560     
+ Partials      318       61      -257     
Flag Coverage Δ
integrationtests 64.83% <0.00%> (-0.11%) ⬇️
unittests 88.85% <100.00%> (+2.93%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.51% <ø> (-13.27%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.79% <100.00%> (+0.07%) ⬆️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.99%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.77% <ø> (-29.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41817c8...386a280. Read the comment docs.

@GitHK
Copy link
Contributor Author

GitHK commented Nov 4, 2024

In this PR, instead of raising, you are filtering and ignoring. right?

correct. I have also updated the description of the PR

@GitHK GitHK enabled auto-merge (squash) November 4, 2024 12:43
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

@GitHK GitHK merged commit d8f1720 into ITISFoundation:master Nov 5, 2024
84 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-fix-disk-usage-error branch November 5, 2024 12:08
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dynamic-sidecar dynamic-sidecar service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants