Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 4, 2024

What do these changes do?

This PR adds two more fields to the Notifications: resource_id and user_from_id.

Thanks to these new fields, the Notification UI element now contains more meaningful information:

{Resource} {NameOfResource}
was shared by {nameOfSharer}
{DateAndTime}

Also when tapping the bell, all the notifications will be marked as read.

New UI:
image

Marked as Read:
MarkAllAsRead

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 4, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 4, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 4, 2024
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.55%. Comparing base (9c6068d) to head (4848909).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9c6068d) and HEAD (4848909). Click for more details.

HEAD has 27 uploads less than BASE
Flag BASE (9c6068d) HEAD (4848909)
unittests 31 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6661      +/-   ##
==========================================
- Coverage   87.94%   82.55%   -5.40%     
==========================================
  Files        1564      613     -951     
  Lines       62982    31345   -31637     
  Branches     2106      265    -1841     
==========================================
- Hits        55389    25876   -29513     
+ Misses       7269     5408    -1861     
+ Partials      324       61     -263     
Flag Coverage Δ
integrationtests 64.84% <100.00%> (+0.02%) ⬆️
unittests 83.63% <100.00%> (-2.29%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.06% <ø> (-13.85%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.79% <ø> (-29.98%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.68% <ø> (-5.47%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 89.27% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6068d...4848909. Read the comment docs.

@odeimaiz odeimaiz marked this pull request as ready for review November 4, 2024 16:34
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔔 thx!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz enabled auto-merge (squash) November 5, 2024 09:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

@odeimaiz odeimaiz merged commit db3aacf into ITISFoundation:master Nov 6, 2024
85 of 89 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

7 participants