Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Nov 4, 2024

What do these changes do?

  • Recently we encountered Rabbit channel closed with exception from <class 'aiormq.exceptions.ConnectionClosed'>:[Errno 320] CONNECTION_FORCED - Node was put into maintenance mode because of maintenance of AWS RabbitMq. This type of issue must be detected in the api-server health check. This PR adds that feature

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Nov 4, 2024
@bisgaard-itis bisgaard-itis added bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing a:apiserver api-server service labels Nov 4, 2024
@bisgaard-itis bisgaard-itis added this to the Event Horizon milestone Nov 4, 2024
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (cb74ff7) to head (d1e7141).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cb74ff7) and HEAD (d1e7141). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (cb74ff7) HEAD (d1e7141)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6662       +/-   ##
===========================================
- Coverage   87.73%   66.96%   -20.77%     
===========================================
  Files        1570      694      -876     
  Lines       63323    33924    -29399     
  Branches     2119      265     -1854     
===========================================
- Hits        55554    22717    -32837     
- Misses       7443    11146     +3703     
+ Partials      326       61      -265     
Flag Coverage Δ
integrationtests 64.87% <ø> (-0.05%) ⬇️
unittests 89.88% <100.00%> (+4.19%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server 89.88% <100.00%> (+0.06%) ⬆️
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.48% <ø> (-14.32%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.82% <ø> (-29.96%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.99%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.79% <ø> (-28.92%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb74ff7...d1e7141. Read the comment docs.

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) November 14, 2024 14:58
@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis merged commit d3e12a3 into ITISFoundation:master Nov 15, 2024
84 of 89 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:apiserver api-server service bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants